gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-07 16:55:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

penalize blob peer on invalid blobs

Browse Source
This commit is contained in:
realbigsean
2023-05-23 16:05:21 -04:00
parent 98d7a1014f
commit 944c9736e7
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
beacon_node/network/src/sync/block_lookups/mod.rs
View File

@@ -855,16 +855,24 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
) )
| BlockError::AvailabilityCheck(AvailabilityCheckError::Kzg(_)) | BlockError::AvailabilityCheck(AvailabilityCheckError::Kzg(_))
| BlockError::BlobValidation(_) => { | BlockError::BlobValidation(_) => {
warn!(self.log, "Availability check failed"; "root" => %root, "error" => ?e, "peer_id" => %peer_id); warn!(self.log, "Blob validation failure"; "root" => %root, "peer_id" => %peer_id);
if let Ok(blob_peer) = request_ref.processing_peer(ResponseType::Blob) {
// Try it again if possible. cx.report_peer(
retry_request_after_failure( blob_peer.to_peer_id(),
request_ref, PeerAction::MidToleranceError,
ResponseType::Blob, "single_blob_failure",
peer_id.as_peer_id(), );
cx, // Try it again if possible.
&self.log, retry_request_after_failure(
) request_ref,
ResponseType::Blob,
peer_id.as_peer_id(),
cx,
&self.log,
)
} else {
ShouldRemoveLookup::False
}
} }
other => { other => {
warn!(self.log, "Peer sent invalid block in single block lookup"; "root" => %root, "error" => ?other, "peer_id" => %peer_id); warn!(self.log, "Peer sent invalid block in single block lookup"; "root" => %root, "error" => ?other, "peer_id" => %peer_id);
@@ -1053,8 +1061,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
// ambiguity. // ambiguity.
cx.report_peer(peer_id, PeerAction::MidToleranceError, "parent_request_err"); cx.report_peer(peer_id, PeerAction::MidToleranceError, "parent_request_err");
// Try again if possible // Try again if possible
//TODO(sean) I don't see why we want to retry here, because this block is invalid and has
// passed block root validation, so querying again by block root will yield the same result.
parent_lookup.block_processing_failed(); parent_lookup.block_processing_failed();
parent_lookup.blob_processing_failed(); parent_lookup.blob_processing_failed();
self.request_parent_block_and_blobs(parent_lookup, cx); self.request_parent_block_and_blobs(parent_lookup, cx);