gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-07-04 13:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Increase penalty for old block gossip spam (#6050)

Browse Source 
* Increase penalty for old block gossip spam
This commit is contained in:
Michael Sproul
2024-07-05 14:30:15 +10:00
committed by GitHub
parent ef956e61e5
commit 94d55be6fa
1 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
beacon_node/network/src/network_beacon_processor/gossip_methods.rs
View File

@@ -1012,11 +1012,12 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Ignore); self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Ignore);
return None; return None;
} }
Err(e @ BlockError::FutureSlot { .. }) Err(e @ BlockError::FutureSlot { .. }) => {
| Err(e @ BlockError::WouldRevertFinalizedSlot { .. }) debug!(
| Err(e @ BlockError::NotFinalizedDescendant { .. }) => { self.log,
debug!(self.log, "Could not verify block for gossip. Ignoring the block"; "Could not verify block for gossip. Ignoring the block";
"error" => %e); "error" => %e
);
// Prevent recurring behaviour by penalizing the peer slightly. // Prevent recurring behaviour by penalizing the peer slightly.
self.gossip_penalize_peer( self.gossip_penalize_peer(
peer_id, peer_id,
@@ -1026,6 +1027,25 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Ignore); self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Ignore);
return None; return None;
} }
Err(e @ BlockError::WouldRevertFinalizedSlot { .. })
| Err(e @ BlockError::NotFinalizedDescendant { .. }) => {
debug!(
self.log,
"Could not verify block for gossip. Ignoring the block";
"error" => %e
);
// The spec says we must IGNORE these blocks but there's no reason for an honest
// and non-buggy client to be gossiping blocks that blatantly conflict with
// finalization. Old versions of Erigon/Caplin are known to gossip pre-finalization
// blocks and we want to isolate them to encourage an update.
self.gossip_penalize_peer(
peer_id,
PeerAction::LowToleranceError,
"gossip_block_low",
);
self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Ignore);
return None;
}
Err(ref e @ BlockError::ExecutionPayloadError(ref epe)) if !epe.penalize_peer() => { Err(ref e @ BlockError::ExecutionPayloadError(ref epe)) if !epe.penalize_peer() => {
debug!(self.log, "Could not verify block for gossip. Ignoring the block"; debug!(self.log, "Could not verify block for gossip. Ignoring the block";
"error" => %e); "error" => %e);