Clear best_child/best_descendant during V28->V29 conversion

2026-04-20 22:38:34 +00:00 · 2026-03-31 15:22:31 -05:00
parent e1cabb8d67
commit 993cecee83
1 changed files with 11 additions and 1 deletions
--- a/consensus/proto_array/src/ssz_container.rs
+++ b/consensus/proto_array/src/ssz_container.rs
@@ -77,7 +77,17 @@ impl From<SszContainerV28> for SszContainerV29 {
        Self {
            votes: v28.votes,
            prune_threshold: v28.prune_threshold,
-            nodes: v28.nodes.into_iter().map(ProtoNode::V17).collect(),
+            nodes: v28
+                .nodes
+                .into_iter()
+                .map(|mut node| {
+                    // best_child/best_descendant are no longer used (replaced by
+                    // the virtual tree walk). Clear during conversion.
+                    node.best_child = None;
+                    node.best_descendant = None;
+                    ProtoNode::V17(node)
+                })
+                .collect(),
            indices: v28.indices,
            previous_proposer_boost: v28.previous_proposer_boost,
        }