gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-04-12 20:49:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Automatically pass spans into blocking handles (#8158)

Browse Source 
Co-Authored-By: Eitan Seri- Levi <eserilev@gmail.com>

Co-Authored-By: Eitan Seri-Levi <eserilev@ucsc.edu>

Co-Authored-By: Jimmy Chen <jchen.tc@gmail.com>
This commit is contained in:
Eitan Seri-Levi
2026-04-01 11:13:20 +09:00
committed by GitHub
parent 03385d698d
commit 99f5a92b98
9 changed files with 29 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
common/task_executor/src/lib.rs
View File

@@ -6,7 +6,7 @@ use futures::channel::mpsc::Sender;
use futures::prelude::*;
use std::sync::{Arc, Weak};
use tokio::runtime::{Handle, Runtime};
use tracing::debug;
use tracing::{Span, debug};
use crate::rayon_pool_provider::RayonPoolProvider;
pub use crate::rayon_pool_provider::RayonPoolType;
@@ -225,9 +225,11 @@ impl TaskExecutor {
F: FnOnce() + Send + 'static,
{
let thread_pool = self.rayon_pool_provider.get_thread_pool(rayon_pool_type);
let span = Span::current();
self.spawn_blocking(
move || {
thread_pool.install(|| {
let _guard = span.enter();
task();
});
},
@@ -247,8 +249,10 @@ impl TaskExecutor {
{
let thread_pool = self.rayon_pool_provider.get_thread_pool(rayon_pool_type);
let (tx, rx) = tokio::sync::oneshot::channel();
let span = Span::current();
thread_pool.spawn(move || {
let _guard = span.enter();
let result = task();
let _ = tx.send(result);
});
@@ -320,8 +324,12 @@ impl TaskExecutor {
let timer = metrics::start_timer_vec(&metrics::BLOCKING_TASKS_HISTOGRAM, &[name]);
metrics::inc_gauge_vec(&metrics::BLOCKING_TASKS_COUNT, &[name]);
let span = Span::current();
let join_handle = if let Some(handle) = self.handle() {
handle.spawn_blocking(task)
handle.spawn_blocking(move || {
let _guard = span.enter();
task()
})
} else {
debug!("Couldn't spawn task. Runtime shutting down");
return None;