mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-09 03:31:45 +00:00
Add Gloas data column support (#8682)
Co-Authored-By: Eitan Seri-Levi <eserilev@ucsc.edu> Co-Authored-By: Eitan Seri- Levi <eserilev@gmail.com>
This commit is contained in:
@@ -693,7 +693,7 @@ fn handle_rpc_response<E: EthSpec>(
|
||||
Some(fork_name) => {
|
||||
if fork_name.fulu_enabled() {
|
||||
Ok(Some(RpcSuccessResponse::DataColumnsByRoot(Arc::new(
|
||||
DataColumnSidecar::from_ssz_bytes(decoded_buffer)?,
|
||||
DataColumnSidecar::from_ssz_bytes_for_fork(decoded_buffer, fork_name)?,
|
||||
))))
|
||||
} else {
|
||||
Err(RPCError::ErrorResponse(
|
||||
@@ -714,7 +714,7 @@ fn handle_rpc_response<E: EthSpec>(
|
||||
Some(fork_name) => {
|
||||
if fork_name.fulu_enabled() {
|
||||
Ok(Some(RpcSuccessResponse::DataColumnsByRange(Arc::new(
|
||||
DataColumnSidecar::from_ssz_bytes(decoded_buffer)?,
|
||||
DataColumnSidecar::from_ssz_bytes_for_fork(decoded_buffer, fork_name)?,
|
||||
))))
|
||||
} else {
|
||||
Err(RPCError::ErrorResponse(
|
||||
@@ -916,6 +916,7 @@ mod tests {
|
||||
SignedBeaconBlockHeader, Slot,
|
||||
data::{BlobIdentifier, Cell},
|
||||
};
|
||||
use types::{BlobSidecar, DataColumnSidecarFulu};
|
||||
|
||||
type Spec = types::MainnetEthSpec;
|
||||
|
||||
@@ -977,7 +978,7 @@ mod tests {
|
||||
fn empty_data_column_sidecar(spec: &ChainSpec) -> Arc<DataColumnSidecar<Spec>> {
|
||||
// The context bytes are now derived from the block epoch, so we need to have the slot set
|
||||
// here.
|
||||
let data_column_sidecar = DataColumnSidecar {
|
||||
let data_column_sidecar = DataColumnSidecar::Fulu(DataColumnSidecarFulu {
|
||||
index: 0,
|
||||
column: VariableList::new(vec![Cell::<Spec>::default()]).unwrap(),
|
||||
kzg_commitments: VariableList::new(vec![KzgCommitment::empty_for_testing()]).unwrap(),
|
||||
@@ -993,7 +994,7 @@ mod tests {
|
||||
signature: Signature::empty(),
|
||||
},
|
||||
kzg_commitments_inclusion_proof: Default::default(),
|
||||
};
|
||||
});
|
||||
Arc::new(data_column_sidecar)
|
||||
}
|
||||
|
||||
|
||||
@@ -15,9 +15,9 @@ use superstruct::superstruct;
|
||||
use types::data::BlobIdentifier;
|
||||
use types::light_client::consts::MAX_REQUEST_LIGHT_CLIENT_UPDATES;
|
||||
use types::{
|
||||
ChainSpec, ColumnIndex, DataColumnSidecar, DataColumnsByRootIdentifier, Epoch, EthSpec,
|
||||
ForkContext, Hash256, LightClientBootstrap, LightClientFinalityUpdate,
|
||||
LightClientOptimisticUpdate, LightClientUpdate, SignedBeaconBlock, Slot, data::BlobSidecar,
|
||||
BlobSidecar, ChainSpec, ColumnIndex, DataColumnSidecar, DataColumnsByRootIdentifier, Epoch,
|
||||
EthSpec, ForkContext, Hash256, LightClientBootstrap, LightClientFinalityUpdate,
|
||||
LightClientOptimisticUpdate, LightClientUpdate, SignedBeaconBlock, Slot,
|
||||
};
|
||||
|
||||
/// Maximum length of error message.
|
||||
@@ -762,12 +762,8 @@ impl<E: EthSpec> RpcSuccessResponse<E> {
|
||||
pub fn slot(&self) -> Option<Slot> {
|
||||
match self {
|
||||
Self::BlocksByRange(r) | Self::BlocksByRoot(r) => Some(r.slot()),
|
||||
Self::BlobsByRange(r) | Self::BlobsByRoot(r) => {
|
||||
Some(r.signed_block_header.message.slot)
|
||||
}
|
||||
Self::DataColumnsByRange(r) | Self::DataColumnsByRoot(r) => {
|
||||
Some(r.signed_block_header.message.slot)
|
||||
}
|
||||
Self::BlobsByRange(r) | Self::BlobsByRoot(r) => Some(r.slot()),
|
||||
Self::DataColumnsByRange(r) | Self::DataColumnsByRoot(r) => Some(r.slot()),
|
||||
Self::LightClientBootstrap(r) => Some(r.get_slot()),
|
||||
Self::LightClientFinalityUpdate(r) => Some(r.get_attested_header_slot()),
|
||||
Self::LightClientOptimisticUpdate(r) => Some(r.get_slot()),
|
||||
|
||||
@@ -17,11 +17,12 @@ use tokio_util::{
|
||||
compat::{Compat, FuturesAsyncReadCompatExt},
|
||||
};
|
||||
use types::{
|
||||
BeaconBlock, BeaconBlockAltair, BeaconBlockBase, BlobSidecar, ChainSpec, DataColumnSidecar,
|
||||
EmptyBlock, Epoch, EthSpec, EthSpecId, ForkContext, ForkName, LightClientBootstrap,
|
||||
LightClientBootstrapAltair, LightClientFinalityUpdate, LightClientFinalityUpdateAltair,
|
||||
LightClientOptimisticUpdate, LightClientOptimisticUpdateAltair, LightClientUpdate,
|
||||
MainnetEthSpec, MinimalEthSpec, SignedBeaconBlock,
|
||||
BeaconBlock, BeaconBlockAltair, BeaconBlockBase, BlobSidecar, ChainSpec, DataColumnSidecarFulu,
|
||||
DataColumnSidecarGloas, EmptyBlock, Epoch, EthSpec, EthSpecId, ForkContext, ForkName,
|
||||
LightClientBootstrap, LightClientBootstrapAltair, LightClientFinalityUpdate,
|
||||
LightClientFinalityUpdateAltair, LightClientOptimisticUpdate,
|
||||
LightClientOptimisticUpdateAltair, LightClientUpdate, MainnetEthSpec, MinimalEthSpec,
|
||||
SignedBeaconBlock,
|
||||
};
|
||||
|
||||
// Note: Hardcoding the `EthSpec` type for `SignedBeaconBlock` as min/max values is
|
||||
@@ -640,10 +641,23 @@ pub fn rpc_data_column_limits<E: EthSpec>(
|
||||
current_digest_epoch: Epoch,
|
||||
spec: &ChainSpec,
|
||||
) -> RpcLimits {
|
||||
RpcLimits::new(
|
||||
DataColumnSidecar::<E>::min_size(),
|
||||
DataColumnSidecar::<E>::max_size(spec.max_blobs_per_block(current_digest_epoch) as usize),
|
||||
)
|
||||
let fork_name = spec.fork_name_at_epoch(current_digest_epoch);
|
||||
|
||||
if fork_name.gloas_enabled() {
|
||||
RpcLimits::new(
|
||||
DataColumnSidecarGloas::<E>::min_size(),
|
||||
DataColumnSidecarGloas::<E>::max_size(
|
||||
spec.max_blobs_per_block(current_digest_epoch) as usize
|
||||
),
|
||||
)
|
||||
} else {
|
||||
RpcLimits::new(
|
||||
DataColumnSidecarFulu::<E>::min_size(),
|
||||
DataColumnSidecarFulu::<E>::max_size(
|
||||
spec.max_blobs_per_block(current_digest_epoch) as usize
|
||||
),
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
/* Inbound upgrade */
|
||||
|
||||
@@ -277,7 +277,7 @@ impl<E: EthSpec> PubsubMessage<E> {
|
||||
match fork_context.get_fork_from_context_bytes(gossip_topic.fork_digest) {
|
||||
Some(fork) if fork.fulu_enabled() => {
|
||||
let col_sidecar = Arc::new(
|
||||
DataColumnSidecar::from_ssz_bytes(data)
|
||||
DataColumnSidecar::from_ssz_bytes_for_fork(data, *fork)
|
||||
.map_err(|e| format!("{:?}", e))?,
|
||||
);
|
||||
Ok(PubsubMessage::DataColumnSidecar(Box::new((
|
||||
@@ -437,7 +437,7 @@ impl<E: EthSpec> std::fmt::Display for PubsubMessage<E> {
|
||||
f,
|
||||
"DataColumnSidecar: slot: {}, column index: {}",
|
||||
data.1.slot(),
|
||||
data.1.index,
|
||||
data.1.index(),
|
||||
),
|
||||
PubsubMessage::AggregateAndProofAttestation(att) => write!(
|
||||
f,
|
||||
|
||||
Reference in New Issue
Block a user