fix some todos

This commit is contained in:
realbigsean
2023-04-25 09:25:24 -04:00
parent 53c0356f8d
commit 9c2aceed10
3 changed files with 8 additions and 30 deletions

View File

@@ -989,8 +989,10 @@ impl<T: BeaconChainTypes> Worker<T> {
);
return None;
}
Err(e @ BlockError::BlobValidation(_)) => {
warn!(self.log, "Could not verify blob for gossip. Rejecting the block and blob";
Err(e @ BlockError::BlobValidation(_))
| Err(e @ BlockError::MissingBlockParts(_, _))
| Err(e @ BlockError::AvailabilityCheck(_)) => {
warn!(self.log, "Could not verify block against known blobs in gossip. Rejecting the block";
"error" => %e);
self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Reject);
self.gossip_penalize_peer(
@@ -1000,7 +1002,6 @@ impl<T: BeaconChainTypes> Worker<T> {
);
return None;
}
_ => todo!(), //TODO(sean)
};
metrics::inc_counter(&metrics::BEACON_PROCESSOR_GOSSIP_BLOCK_VERIFIED_TOTAL);

View File

@@ -984,11 +984,11 @@ impl<T: BeaconChainTypes> SyncManager<T> {
seen_timestamp,
&mut self.network,
),
RequestId::BackFillBlocks { id } => {
todo!()
RequestId::BackFillBlocks { id: _ } => {
warn!(self.log, "Blob received during backfill block request"; "peer_id" => %peer_id );
}
RequestId::RangeBlocks { id } => {
todo!()
RequestId::RangeBlocks { id: _ } => {
warn!(self.log, "Blob received during range block request"; "peer_id" => %peer_id );
}
RequestId::BackFillBlockAndBlobs { id } => {
self.backfill_block_and_blobs_response(id, peer_id, blob.into())