gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-08 17:26:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

import envelope status into fc

Browse Source
This commit is contained in:
Eitan Seri- Levi
2026-03-30 23:50:31 -07:00
parent 5353710e0a
commit 9f08f48880
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
beacon_node/beacon_chain/src/payload_envelope_verification/import.rs
View File

@@ -239,16 +239,14 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
// Note that a duplicate cache/payload status table should prevent this from happening // Note that a duplicate cache/payload status table should prevent this from happening
// but it doesnt hurt to be defensive. // but it doesnt hurt to be defensive.
// TODO(gloas) when the code below is implemented we can delete this drop
drop(fork_choice_reader);
// TODO(gloas) no fork choice logic yet
// Take an exclusive write-lock on fork choice. It's very important to prevent deadlocks by // Take an exclusive write-lock on fork choice. It's very important to prevent deadlocks by
// avoiding taking other locks whilst holding this lock. // avoiding taking other locks whilst holding this lock.
// let fork_choice = parking_lot::RwLockUpgradableReadGuard::upgrade(fork_choice_reader); let mut fork_choice = parking_lot::RwLockUpgradableReadGuard::upgrade(fork_choice_reader);
// TODO(gloas) Do we need this check? Do not import a block that doesn't descend from the finalized root. // Update the node's payload_status from PENDING to FULL in fork choice.
// let signed_block = check_block_is_finalized_checkpoint_or_descendant(self, &fork_choice, signed_block)?; fork_choice
.on_execution_payload(block_root)
.map_err(|e| EnvelopeError::InternalError(format!("{e:?}")))?;
// TODO(gloas) emit SSE event if the payload became the new head payload // TODO(gloas) emit SSE event if the payload became the new head payload
@@ -302,10 +300,9 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
drop(db_span); drop(db_span);
// TODO(gloas) drop fork choice lock
// The fork choice write-lock is dropped *after* the on-disk database has been updated. // The fork choice write-lock is dropped *after* the on-disk database has been updated.
// This prevents inconsistency between the two at the expense of concurrency. // This prevents inconsistency between the two at the expense of concurrency.
// drop(fork_choice); drop(fork_choice);
// We're declaring the envelope "imported" at this point, since fork choice and the DB know // We're declaring the envelope "imported" at this point, since fork choice and the DB know
// about it. // about it.