mirror of
https://github.com/sigp/lighthouse.git
synced 2026-04-26 09:13:41 +00:00
Check ChainSpec consistency with upstream config.yaml (#9008)
Closes: - https://github.com/sigp/lighthouse/issues/9002 - Commit `config.yaml` for minimal and mainnet to `consensus/types/configs`. For now we omit any auto-downloading logic, to avoid the hassles of dealing with Github rate limits etc on CI. Unfortunately these files are NOT bundled inside the spec tests. - Fix the values of `min_builder_withdrawability_delay` for minimal and mainnet. These discrepancies aren't caught by the current spec tests, because the spec tests are missing data: https://github.com/ethereum/consensus-specs/pull/5005. Will be fixed in the next release/when we update to nightly. - Fix the blob schedule for `minimal`, which should be empty, NOT inherited from mainnet. - Keep `SECONDS_PER_SLOT` for now because the Kurtosis tests fail upon their complete removal. We will be able to completely remove `SECONDS_PER_SLOT` soon. Co-Authored-By: Michael Sproul <michael@sigmaprime.io>
This commit is contained in:
@@ -2910,7 +2910,7 @@ async fn reproduction_unaligned_checkpoint_sync_pruned_payload() {
|
||||
let slot_clock = TestingSlotClock::new(
|
||||
Slot::new(0),
|
||||
Duration::from_secs(harness.chain.genesis_time),
|
||||
Duration::from_secs(spec.seconds_per_slot),
|
||||
spec.get_slot_duration(),
|
||||
);
|
||||
slot_clock.set_slot(harness.get_current_slot().as_u64());
|
||||
|
||||
@@ -5334,8 +5334,8 @@ async fn test_safely_backfill_data_column_custody_info() {
|
||||
.await;
|
||||
|
||||
let epoch_before_increase = Epoch::new(start_epochs);
|
||||
let effective_delay_slots =
|
||||
CUSTODY_CHANGE_DA_EFFECTIVE_DELAY_SECONDS / harness.chain.spec.seconds_per_slot;
|
||||
let effective_delay_slots = CUSTODY_CHANGE_DA_EFFECTIVE_DELAY_SECONDS
|
||||
/ harness.chain.spec.get_slot_duration().as_secs();
|
||||
|
||||
let cgc_change_slot = epoch_before_increase.end_slot(E::slots_per_epoch());
|
||||
|
||||
@@ -6133,7 +6133,7 @@ async fn bellatrix_produce_and_store_payloads() {
|
||||
.genesis_time()
|
||||
.safe_add(
|
||||
slot.as_u64()
|
||||
.safe_mul(harness.spec.seconds_per_slot)
|
||||
.safe_mul(harness.spec.get_slot_duration().as_secs())
|
||||
.unwrap(),
|
||||
)
|
||||
.unwrap();
|
||||
|
||||
Reference in New Issue
Block a user