Update to frozen spec ❄️ (v0.8.1) (#444)

* types: first updates for v0.8 * state_processing: epoch processing v0.8.0 * state_processing: block processing v0.8.0 * tree_hash_derive: support generics in SignedRoot * types v0.8: update to use ssz_types * state_processing v0.8: use ssz_types * ssz_types: add bitwise methods and from_elem * types: fix v0.8 FIXMEs * ssz_types: add bitfield shift_up * ssz_types: iterators and DerefMut for VariableList * types,state_processing: use VariableList * ssz_types: fix BitVector Decode impl Fixed a typo in the implementation of ssz::Decode for BitVector, which caused it to be considered variable length! * types: fix test modules for v0.8 update * types: remove slow type-level arithmetic * state_processing: fix tests for v0.8 * op_pool: update for v0.8 * ssz_types: Bitfield difference length-independent Allow computing the difference of two bitfields of different lengths. * Implement compact committee support * epoch_processing: committee & active index roots * state_processing: genesis state builder v0.8 * state_processing: implement v0.8.1 * Further improve tree_hash * Strip examples, tests from cached_tree_hash * Update TreeHash, un-impl CachedTreeHash * Update bitfield TreeHash, un-impl CachedTreeHash * Update FixedLenVec TreeHash, unimpl CachedTreeHash * Update update tree_hash_derive for new TreeHash * Fix TreeHash, un-impl CachedTreeHash for ssz_types * Remove fixed_len_vec, ssz benches SSZ benches relied upon fixed_len_vec -- it is easier to just delete them and rebuild them later (when necessary) * Remove boolean_bitfield crate * Fix fake_crypto BLS compile errors * Update ef_tests for new v.8 type params * Update ef_tests submodule to v0.8.1 tag * Make fixes to support parsing ssz ef_tests * `compact_committee...` to `compact_committees...` * Derive more traits for `CompactCommittee` * Flip bitfield byte-endianness * Fix tree_hash for bitfields * Modify CLI output for ef_tests * Bump ssz crate version * Update ssz_types doc comment * Del cached tree hash tests from ssz_static tests * Tidy SSZ dependencies * Rename ssz_types crate to eth2_ssz_types * validator_client: update for v0.8 * ssz_types: update union/difference for bit order swap * beacon_node: update for v0.8, EthSpec * types: disable cached tree hash, update min spec * state_processing: fix slot bug in committee update * tests: temporarily disable fork choice harness test See #447 * committee cache: prevent out-of-bounds access In the case where we tried to access the committee of a shard that didn't have a committee in the current epoch, we were accessing elements beyond the end of the shuffling vector and panicking! This commit adds a check to make the failure safe and explicit. * fix bug in get_indexed_attestation and simplify There was a bug in our implementation of get_indexed_attestation whereby incorrect "committee indices" were used to index into the custody bitfield. The bug was only observable in the case where some bits of the custody bitfield were set to 1. The implementation has been simplified to remove the bug, and a test added. * state_proc: workaround for compact committees bug https://github.com/ethereum/eth2.0-specs/issues/1315 * v0.8: updates to make the EF tests pass * Remove redundant max operation checks. * Always supply both messages when checking attestation signatures -- allowing verification of an attestation with no signatures. * Swap the order of the fork and domain constant in `get_domain`, to match the spec. * rustfmt * ef_tests: add new epoch processing tests * Integrate v0.8 into master (compiles) * Remove unused crates, fix clippy lints * Replace v0.6.3 tags w/ v0.8.1 * Remove old comment * Ensure lmd ghost tests only run in release * Update readme
2026-03-23 06:44:35 +00:00 · 2019-07-30 12:44:51 +10:00
parent 177df12149
commit a236003a7b
184 changed files with 3332 additions and 4542 deletions
--- a/eth2/state_processing/src/per_block_processing/errors.rs
+++ b/eth2/state_processing/src/per_block_processing/errors.rs
@@ -59,6 +59,8 @@ pub enum BlockProcessingError {
    Invalid(BlockInvalid),
    /// Encountered a `BeaconStateError` whilst attempting to determine validity.
    BeaconStateError(BeaconStateError),
+    /// Encountered an `ssz_types::Error` whilst attempting to determine validity.
+    SszTypesError(ssz_types::Error),
 }

 impl_from_beacon_state_error!(BlockProcessingError);
@@ -78,6 +80,7 @@ pub enum BlockInvalid {
    MaxAttesterSlashingsExceed,
    MaxProposerSlashingsExceeded,
    DepositCountInvalid,
+    DuplicateTransfers,
    MaxExitsExceeded,
    MaxTransfersExceed,
    AttestationInvalid(usize, AttestationInvalid),
@@ -92,6 +95,15 @@ pub enum BlockInvalid {
    DepositProcessingFailed(usize),
    ExitInvalid(usize, ExitInvalid),
    TransferInvalid(usize, TransferInvalid),
+    // NOTE: this is only used in tests, normally a state root mismatch is handled
+    // in the beacon_chain rather than in state_processing
+    StateRootMismatch,
+}
+
+impl From<ssz_types::Error> for BlockProcessingError {
+    fn from(error: ssz_types::Error) -> Self {
+        BlockProcessingError::SszTypesError(error)
+    }
 }

 impl Into<BlockProcessingError> for BlockInvalid {
@@ -116,8 +128,8 @@ pub enum AttestationValidationError {
 /// Describes why an object is invalid.
 #[derive(Debug, PartialEq)]
 pub enum AttestationInvalid {
-    /// Attestation references a pre-genesis slot.
-    PreGenesis { genesis: Slot, attestation: Slot },
+    /// Shard exceeds SHARD_COUNT.
+    BadShard,
    /// Attestation included before the inclusion delay.
    IncludedTooEarly {
        state: Slot,
@@ -128,27 +140,23 @@ pub enum AttestationInvalid {
    IncludedTooLate { state: Slot, attestation: Slot },
    /// Attestation target epoch does not match the current or previous epoch.
    BadTargetEpoch,
-    /// Attestation justified epoch does not match the states current or previous justified epoch.
+    /// Attestation justified checkpoint doesn't match the state's current or previous justified
+    /// checkpoint.
    ///
    /// `is_current` is `true` if the attestation was compared to the
-    /// `state.current_justified_epoch`, `false` if compared to `state.previous_justified_epoch`.
-    WrongJustifiedEpoch {
-        state: Epoch,
-        attestation: Epoch,
-        is_current: bool,
-    },
-    /// Attestation justified epoch root does not match root known to the state.
-    ///
-    /// `is_current` is `true` if the attestation was compared to the
-    /// `state.current_justified_epoch`, `false` if compared to `state.previous_justified_epoch`.
-    WrongJustifiedRoot {
-        state: Hash256,
-        attestation: Hash256,
+    /// `state.current_justified_checkpoint`, `false` if compared to `state.previous_justified_checkpoint`.
+    WrongJustifiedCheckpoint {
+        state: Checkpoint,
+        attestation: Checkpoint,
        is_current: bool,
    },
    /// Attestation crosslink root does not match the state crosslink root for the attestations
    /// slot.
-    BadPreviousCrosslink,
+    BadParentCrosslinkHash,
+    /// Attestation crosslink start epoch does not match the end epoch of the state crosslink.
+    BadParentCrosslinkStartEpoch,
+    /// Attestation crosslink end epoch does not match the expected value.
+    BadParentCrosslinkEndEpoch,
    /// The custody bitfield has some bits set `true`. This is not allowed in phase 0.
    CustodyBitfieldHasSetBits,
    /// There are no set bits on the attestation -- an attestation must be signed by at least one
@@ -164,6 +172,8 @@ pub enum AttestationInvalid {
        committee_len: usize,
        bitfield_len: usize,
    },
+    /// The bits set in the custody bitfield are not a subset of those set in the aggregation bits.
+    CustodyBitfieldNotSubset,
    /// There was no known committee in this `epoch` for the given shard and slot.
    NoCommitteeForShard { shard: u64, slot: Slot },
    /// The validator index was unknown.
@@ -186,6 +196,12 @@ impl From<IndexedAttestationValidationError> for AttestationValidationError {
    }
 }

+impl From<ssz_types::Error> for AttestationValidationError {
+    fn from(error: ssz_types::Error) -> Self {
+        Self::from(IndexedAttestationValidationError::from(error))
+    }
+}
+
 /*
 * `AttesterSlashing` Validation
 */
@@ -239,12 +255,14 @@ pub enum IndexedAttestationInvalid {
    CustodyBitValidatorsIntersect,
    /// The custody bitfield has some bits set `true`. This is not allowed in phase 0.
    CustodyBitfieldHasSetBits,
+    /// The custody bitfield violated a type-level bound.
+    CustodyBitfieldBoundsError(ssz_types::Error),
    /// No validator indices were specified.
    NoValidatorIndices,
    /// The number of indices exceeds the global maximum.
    ///
    /// (max_indices, indices_given)
-    MaxIndicesExceed(u64, usize),
+    MaxIndicesExceed(usize, usize),
    /// The validator indices were not in increasing order.
    ///
    /// The error occurred between the given `index` and `index + 1`
@@ -263,6 +281,14 @@ impl Into<IndexedAttestationInvalid> for IndexedAttestationValidationError {
    }
 }

+impl From<ssz_types::Error> for IndexedAttestationValidationError {
+    fn from(error: ssz_types::Error) -> Self {
+        IndexedAttestationValidationError::Invalid(
+            IndexedAttestationInvalid::CustodyBitfieldBoundsError(error),
+        )
+    }
+}
+
 impl_into_with_index_without_beacon_error!(
    IndexedAttestationValidationError,
    IndexedAttestationInvalid
@@ -356,7 +382,10 @@ pub enum ExitInvalid {
    /// The exit is for a future epoch.
    FutureEpoch { state: Epoch, exit: Epoch },
    /// The validator has not been active for long enough.
-    TooYoungToLeave { lifespan: Epoch, expected: u64 },
+    TooYoungToExit {
+        current_epoch: Epoch,
+        earliest_exit_epoch: Epoch,
+    },
    /// The exit signature was not signed by the validator.
    BadSignature,
 }