From ad229a63c033de0b51441963e195fd6fa6594abc Mon Sep 17 00:00:00 2001 From: Jimmy Chen Date: Wed, 23 Oct 2024 09:51:42 +1100 Subject: [PATCH] Use `make cli-local` in CI test suite to remove redundant docker (#6531) * Remove docker command from `make cli`. * Run `cli-local` on CI. * Update Makefile Co-authored-by: Mac L --- .github/workflows/test-suite.yml | 2 +- Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index 7cda3e477d..a80470cf16 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -420,7 +420,7 @@ jobs: channel: stable cache-target: release - name: Run Makefile to trigger the bash script - run: make cli + run: make cli-local # This job succeeds ONLY IF all others succeed. It is used by the merge queue to determine whether # a PR is safe to merge. New jobs should be added here. test-suite-success: diff --git a/Makefile b/Makefile index 32665d43ae..fd7d45f26a 100644 --- a/Makefile +++ b/Makefile @@ -183,7 +183,7 @@ test-exec-engine: # test vectors. test: test-release -# Updates the CLI help text pages in the Lighthouse book, building with Docker. +# Updates the CLI help text pages in the Lighthouse book, building with Docker (primarily for Windows users). cli: docker run --rm --user=root \ -v ${PWD}:/home/runner/actions-runner/lighthouse sigmaprime/github-runner \