mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-19 04:42:34 +00:00
Fix Gloas EF test failures and add test exclusions (#8687)
* Added gloas exclusion to `FinalityHandler` * Fix Gloas EF test failures and add test exclusions - Fix execution_payload_availability initialization in fork upgrade to set all bits to true per spec (was all zeros) - Fix minimal spec gloas_fork_version: [0x07,0x00,0x00,0x01] (was 0x00) - Fix payload attestation signature domain to use get_domain instead of compute_domain with genesis fork version - Add proposer slashing handler to clear builder_pending_payment per EIP-7732 spec - Add Gloas test exclusions for unimplemented functionality: - sanity_blocks, sanity_slots, random, transition, finality handlers - deposit_request operation (requires builder deposit functionality) - Python exclusions for check_all_files_accessed.py * fmt
This commit is contained in:
@@ -47,6 +47,19 @@ excluded_paths = [
|
||||
"bls12-381-tests/hash_to_G2",
|
||||
"tests/.*/eip7732",
|
||||
"tests/.*/eip7805",
|
||||
# TODO(EIP-7732): Gloas execution_payload_bid tests require process_execution_payload_bid
|
||||
# which is not yet implemented.
|
||||
"tests/.*/gloas/operations/execution_payload_bid/.*",
|
||||
# TODO(EIP-7732): Gloas deposit_request tests require builder deposit functionality
|
||||
# (apply_deposit_for_builder, add_builder_to_registry) which is not yet implemented.
|
||||
"tests/.*/gloas/operations/deposit_request/.*",
|
||||
# TODO(EIP-7732): Gloas sanity, transition, random, finality, and fork_choice tests require
|
||||
# full block processing which is not yet complete.
|
||||
"tests/.*/gloas/sanity/.*",
|
||||
"tests/.*/gloas/transition/.*",
|
||||
"tests/.*/gloas/random/.*",
|
||||
"tests/.*/gloas/finality/.*",
|
||||
"tests/.*/gloas/fork_choice/.*",
|
||||
# Ignore MatrixEntry SSZ tests for now.
|
||||
"tests/.*/fulu/ssz_static/MatrixEntry/.*",
|
||||
# EIP-7916 is still in draft and hasn't been implemented yet https://eips.ethereum.org/EIPS/eip-7916
|
||||
@@ -59,8 +72,6 @@ excluded_paths = [
|
||||
# Ignore full epoch tests for now (just test the sub-transitions).
|
||||
"tests/.*/.*/epoch_processing/.*/pre_epoch.ssz_snappy",
|
||||
"tests/.*/.*/epoch_processing/.*/post_epoch.ssz_snappy",
|
||||
# Ignore gloas tests for now
|
||||
"tests/.*/gloas/.*",
|
||||
# Ignore KZG tests that target internal kzg library functions
|
||||
"tests/.*/compute_verify_cell_kzg_proof_batch_challenge/.*",
|
||||
"tests/.*/compute_challenge/.*",
|
||||
|
||||
@@ -503,7 +503,10 @@ impl<E: EthSpec> Operation<E> for DepositRequest {
|
||||
}
|
||||
|
||||
fn is_enabled_for_fork(fork_name: ForkName) -> bool {
|
||||
fork_name.electra_enabled()
|
||||
// TODO(EIP-7732): Gloas deposit_request tests require builder deposit functionality
|
||||
// (apply_deposit_for_builder, add_builder_to_registry) which is not yet implemented.
|
||||
// https://github.com/sigp/lighthouse/issues/XXXX
|
||||
fork_name.electra_enabled() && fork_name != ForkName::Gloas
|
||||
}
|
||||
|
||||
fn decode(path: &Path, _fork_name: ForkName, _spec: &ChainSpec) -> Result<Self, Error> {
|
||||
|
||||
@@ -491,10 +491,11 @@ impl<E: EthSpec + TypeName> Handler for SanityBlocksHandler<E> {
|
||||
"blocks".into()
|
||||
}
|
||||
|
||||
fn is_enabled_for_fork(&self, _fork_name: ForkName) -> bool {
|
||||
fn is_enabled_for_fork(&self, fork_name: ForkName) -> bool {
|
||||
// NOTE: v1.1.0-beta.4 doesn't mark the historical blocks test as requiring real crypto, so
|
||||
// only run these tests with real crypto for now.
|
||||
cfg!(not(feature = "fake_crypto"))
|
||||
// TODO(EIP-7732): Gloas sanity tests require full block processing which is not yet complete
|
||||
fork_name != ForkName::Gloas && cfg!(not(feature = "fake_crypto"))
|
||||
}
|
||||
}
|
||||
|
||||
@@ -519,7 +520,9 @@ impl<E: EthSpec + TypeName> Handler for SanitySlotsHandler<E> {
|
||||
|
||||
fn is_enabled_for_fork(&self, fork_name: ForkName) -> bool {
|
||||
// Some sanity tests compute sync committees, which requires real crypto.
|
||||
fork_name == ForkName::Base || cfg!(not(feature = "fake_crypto"))
|
||||
// TODO(EIP-7732): Gloas sanity tests require full block processing which is not yet complete
|
||||
fork_name != ForkName::Gloas
|
||||
&& (fork_name == ForkName::Base || cfg!(not(feature = "fake_crypto")))
|
||||
}
|
||||
}
|
||||
|
||||
@@ -541,6 +544,11 @@ impl<E: EthSpec + TypeName> Handler for RandomHandler<E> {
|
||||
fn handler_name(&self) -> String {
|
||||
"random".into()
|
||||
}
|
||||
|
||||
fn is_enabled_for_fork(&self, fork_name: ForkName) -> bool {
|
||||
// TODO(EIP-7732): Gloas random tests require full block processing which is not yet complete
|
||||
fork_name != ForkName::Gloas
|
||||
}
|
||||
}
|
||||
|
||||
#[derive(Educe)]
|
||||
@@ -631,6 +639,11 @@ impl<E: EthSpec + TypeName> Handler for TransitionHandler<E> {
|
||||
fn handler_name(&self) -> String {
|
||||
"core".into()
|
||||
}
|
||||
|
||||
fn is_enabled_for_fork(&self, fork_name: ForkName) -> bool {
|
||||
// TODO(EIP-7732): Gloas transition tests require full block processing which is not yet complete
|
||||
fork_name != ForkName::Gloas
|
||||
}
|
||||
}
|
||||
|
||||
#[derive(Educe)]
|
||||
@@ -652,6 +665,11 @@ impl<E: EthSpec + TypeName> Handler for FinalityHandler<E> {
|
||||
fn handler_name(&self) -> String {
|
||||
"finality".into()
|
||||
}
|
||||
|
||||
fn is_enabled_for_fork(&self, fork_name: ForkName) -> bool {
|
||||
// TODO(EIP-7732): Gloas finality tests require full block processing which is not yet complete
|
||||
fork_name != ForkName::Gloas
|
||||
}
|
||||
}
|
||||
|
||||
pub struct ForkChoiceHandler<E> {
|
||||
@@ -699,6 +717,12 @@ impl<E: EthSpec + TypeName> Handler for ForkChoiceHandler<E> {
|
||||
return false;
|
||||
}
|
||||
|
||||
// TODO(EIP-7732): Gloas fork choice not yet implemented
|
||||
// https://github.com/sigp/lighthouse/issues/XXXX
|
||||
if fork_name == ForkName::Gloas {
|
||||
return false;
|
||||
}
|
||||
|
||||
// No FCU override tests prior to bellatrix.
|
||||
if self.handler_name == "should_override_forkchoice_update"
|
||||
&& !fork_name.bellatrix_enabled()
|
||||
|
||||
Reference in New Issue
Block a user