gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-03 00:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix visual bug on visualize_batch_state leading to a non-wanted comma (#8499)

Browse Source 
Which issue # does this PR address?
None


  The `visualize_batch_state`  functions uses the following loop `for mut batch_index in 0..BATCH_BUFFER_SIZE`, making it from `0` to `BATCH_BUFFER_SIZE - 1` (behind the scenes).

Hence we would never hit the following condition:

```rust
if batch_index != BATCH_BUFFER_SIZE {
visualization_string.push(',');
}
```

Replacing `!=` with `<` & `BATCH_BUFFER_SIZE -1` allows for the following change:

`[A,B,C,D,E,]` to become: `[A,B,C,D,E]`


Co-Authored-By: Antoine James <antoine@ethereum.org>
This commit is contained in:
0xMushow
2025-12-15 06:14:15 +01:00
committed by GitHub
parent ac8d77369d
commit afa6457acf
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
beacon_node/network/src/sync/range_sync/chain.rs
View File

@@ -1331,7 +1331,7 @@ impl<T: BeaconChainTypes> SyncingChain<T> {
.get(&(self.processing_target + batch_index as u64 * EPOCHS_PER_BATCH))
{
visualization_string.push(batch.visualize());
if batch_index != BATCH_BUFFER_SIZE {
if batch_index < BATCH_BUFFER_SIZE - 1 {
// Add a comma in between elements
visualization_string.push(',');
}