Improve block lookup logging (#5535)

* Improve block lookup logging
This commit is contained in:
Lion - dapplion
2024-04-09 23:25:18 +09:00
committed by GitHub
parent 32be063f0f
commit b74da14261
4 changed files with 62 additions and 29 deletions

View File

@@ -249,6 +249,9 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
self.da_checker.clone(),
cx,
);
debug!(self.log, "Created new parent lookup"; "block_root" => ?block_root, "parent_root" => ?parent_root);
self.request_parent(parent_lookup, cx);
}
@@ -575,7 +578,7 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
| ParentVerifyError::ExtraBlobsReturned
| ParentVerifyError::InvalidIndex(_) => {
let e = e.into();
warn!(self.log, "Peer sent invalid response to parent request.";
warn!(self.log, "Peer sent invalid response to parent request";
"peer_id" => %peer_id, "reason" => %e);
// We do not tolerate these kinds of errors. We will accept a few but these are signs
@@ -661,7 +664,7 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
.position(|req| req.check_peer_disconnected(peer_id).is_err())
{
let parent_lookup = self.parent_lookups.remove(pos);
trace!(self.log, "Parent lookup's peer disconnected"; &parent_lookup);
debug!(self.log, "Dropping parent lookup after peer disconnected"; &parent_lookup);
self.request_parent(parent_lookup, cx);
}
}
@@ -745,14 +748,19 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
cx: &mut SyncNetworkContext<T>,
) {
let Some(mut lookup) = self.single_block_lookups.remove(&target_id) else {
debug!(self.log, "Unknown single block lookup"; "target_id" => target_id);
return;
};
let root = lookup.block_root();
let request_state = R::request_state_mut(&mut lookup);
let Ok(peer_id) = request_state.get_state().processing_peer() else {
return;
let peer_id = match request_state.get_state().processing_peer() {
Ok(peer_id) => peer_id,
Err(e) => {
debug!(self.log, "Attempting to process single block lookup in bad state"; "id" => target_id, "response_type" => ?R::response_type(), "error" => e);
return;
}
};
debug!(
self.log,