gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-19 21:04:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Lint for sum and product in consensus code (#2226)

Browse Source 
## Issue Addressed

Closes #1621

## Proposed Changes

Use the `disallowed_method` lint to ban uses of `Iterator::{sum,product}` from `types` and `state_processing`.

## Additional Info

The lint is turned off in the tree hash caching code, as it is performance sensitive and overflowy arithmetic is already allowed there.
This commit is contained in:
Michael Sproul
2021-03-01 00:57:13 +00:00
parent 0b2ccecbcf
commit baef1db40f
5 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
consensus/state_processing/clippy.toml Normal file
View File

@@ -0,0 +1,5 @@
# Disallow sum and product methods which are prone to overflow.
disallowed-methods = [
"core::iter::traits::iterator::Iterator::sum",
"core::iter::traits::iterator::Iterator::product",
]