From c55b94053bc2f919a1b6189fd917f5c9c03c0400 Mon Sep 17 00:00:00 2001 From: Paul Hauner Date: Mon, 24 Sep 2018 18:09:01 +1000 Subject: [PATCH] Tidy validation signatures --- lighthouse/state/validation/signatures.rs | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/lighthouse/state/validation/signatures.rs b/lighthouse/state/validation/signatures.rs index 30f2339b22..302c13f630 100644 --- a/lighthouse/state/validation/signatures.rs +++ b/lighthouse/state/validation/signatures.rs @@ -18,11 +18,12 @@ pub enum SignatureVerificationError { DBError(String), } -fn verify_aggregate_signature_for_indices(message: &[u8], - agg_sig: &AggregateSignature, - attestation_indices: &[usize], - bitfield: &Bitfield, - validator_store: &ValidatorStore) +pub fn verify_aggregate_signature_for_indices( + message: &[u8], + agg_sig: &AggregateSignature, + attestation_indices: &[usize], + bitfield: &Bitfield, + validator_store: &ValidatorStore) -> Result<(bool, Option>), SignatureVerificationError> where T: ClientDB + Sized { @@ -68,6 +69,15 @@ mod tests { use super::super::db::MemoryDB; use std::sync::Arc; + /* + * Cases that still need testing: + * + * - No signatures. + * - Database failure. + * - Unknown validator index. + * - Extra validator on signature. + */ + #[test] fn test_signature_verification() { let message = "cats".as_bytes();