gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-03 00:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Emit NewHead SSE event earlier in block import (#8718)

Browse Source 
Co-Authored-By: Jimmy Chen <jchen.tc@gmail.com>
This commit is contained in:
Jimmy Chen
2026-01-29 18:39:05 +11:00
committed by GitHub
parent 119dc565a1
commit cd8049a696
4 changed files with 107 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
beacon_node/http_api/tests/tests.rs
View File

@@ -6539,8 +6539,13 @@ impl ApiTester {
block_events.as_slice(),
&[
expected_gossip,
expected_block,
// SSE `Head`` event is now emitted before `Block` event, because we only emit the block event
// after it's persisted to the database. We could consider changing this later, but
// we might have to serve http API requests for blocks from early_attester_cache
// before they're persisted to the database.
// https://github.com/sigp/lighthouse/pull/8718#issuecomment-3815593310
expected_head,
expected_block,
expected_finalized
]
);
@@ -6797,7 +6802,12 @@ impl ApiTester {
.unwrap();
let block_events = poll_events(&mut events_future, 2, Duration::from_millis(10000)).await;
assert_eq!(block_events.as_slice(), &[expected_block, expected_head]);
// SSE `Head`` event is now emitted before `Block` event, because we only emit the block event
// after it's persisted to the database. We could consider changing this later, but
// we might have to serve http API requests for blocks from early_attester_cache
// before they're persisted to the database.
// https://github.com/sigp/lighthouse/pull/8718#issuecomment-3815593310
assert_eq!(block_events.as_slice(), &[expected_head, expected_block]);
self
}