gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-11 18:04:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

UX Network Fixes (#6796)

Browse Source 
There were two things I came across during some recent testing, that this PR addresses.

1 - The default port for IPv6 was set to 9090, which is confusing. I've set this to match its ipv4 counterpart (i.e 9000 and 9001). This makes more sense and is easier to firewall, for those firewalls that support both versions for a single rule.

2 - Watching the NAT status of lighthouse, I notice we only set the field to 1 once the NAT is passed. We don't give it a default 0 (false). So we only see results when its successful. On peer disconnects, i've piggy-backed a loop of the connected peers to also watch and check for NAT status updates.
This commit is contained in:
Age Manning
2025-02-04 12:28:37 +11:00
committed by GitHub
parent df131b2a6c
commit d1061dcf59
4 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
beacon_node/src/cli.rs
View File

@@ -176,8 +176,7 @@ pub fn cli_app() -> Command {
.long("port6")
.value_name("PORT")
.help("The TCP/UDP ports to listen on over IPv6 when listening over both IPv4 and \
IPv6. Defaults to 9090 when required. The Quic UDP port will be set to this value + 1.")
.default_value("9090")
IPv6. Defaults to --port. The Quic UDP port will be set to this value + 1.")
.action(ArgAction::Set)
.display_order(0)
)