gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-16 03:12:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Resolve some PeerDAS todos (#6434)

Browse Source 
* Resolve some PeerDAS todos
This commit is contained in:
Lion - dapplion
2024-11-05 09:39:58 +02:00
committed by GitHub
parent 38388979db
commit d8dbda319d
3 changed files with 10 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
beacon_node/network/src/sync/manager.rs
View File

@@ -1188,22 +1188,14 @@ impl<T: BeaconChainTypes> SyncManager<T> {
}
fn on_sampling_result(&mut self, requester: SamplingRequester, result: SamplingResult) {
// TODO(das): How is a consumer of sampling results?
// - Fork-choice for trailing DA
// - Single lookups to complete import requirements
// - Range sync to complete import requirements? Can sampling for syncing lag behind and
// accumulate in fork-choice?
match requester {
SamplingRequester::ImportedBlock(block_root) => {
debug!(self.log, "Sampling result"; "block_root" => %block_root, "result" => ?result);
// TODO(das): Consider moving SamplingResult to the beacon_chain crate and import
// here. No need to add too much enum variants, just whatever the beacon_chain or
// fork-choice needs to make a decision. Currently the fork-choice only needs to
// be notified of successful samplings, i.e. sampling failures don't trigger pruning
match result {
Ok(_) => {
// Notify the fork-choice of a successful sampling result to mark the block
// branch as safe.
if let Err(e) = self
.network
.beacon_processor()