Drop null_logger (#6013)

* Drop null_logger

common/logging/src/lib.rs

@@ -289,10 +289,10 @@ pub fn test_logger() -> Logger {
         sloggers::terminal::TerminalLoggerBuilder::new()
             .level(sloggers::types::Severity::Debug)
             .build()
-            .expect("Should build test_logger")
+            .expect("Should build TerminalLoggerBuilder")
     } else {
         sloggers::null::NullLoggerBuilder
             .build()
-            .expect("Should build null_logger")
+            .expect("Should build NullLoggerBuilder")
     }
 }

common/task_executor/src/test_utils.rs

@@ -1,7 +1,6 @@
 use crate::TaskExecutor;
-use logging::test_logger;
+pub use logging::test_logger;
 use slog::Logger;
-use sloggers::{null::NullLoggerBuilder, Build};
 use std::sync::Arc;
 use tokio::runtime;
 
@@ -67,10 +66,3 @@ impl TestRuntime {
         self.task_executor.log = log;
     }
 }
-
-pub fn null_logger() -> Result<Logger, String> {
-    let log_builder = NullLoggerBuilder;
-    log_builder
-        .build()
-        .map_err(|e| format!("Failed to start null logger: {:?}", e))
-}