Move dependencies to workspace (#4650)

## Issue Addressed

Synchronize dependencies and edition on the workspace `Cargo.toml`

## Proposed Changes

with https://github.com/rust-lang/cargo/issues/8415 merged it's now possible to synchronize details on the workspace `Cargo.toml` like the metadata and dependencies.
By only having dependencies that are shared between multiple crates aligned on the workspace `Cargo.toml` it's easier to not miss duplicate versions of the same dependency and therefore ease on the compile times.

## Additional Info
this PR also removes the no longer required direct dependency of the `serde_derive` crate.

should be reviewed after https://github.com/sigp/lighthouse/pull/4639 get's merged.
closes https://github.com/sigp/lighthouse/issues/4651


Co-authored-by: Michael Sproul <michael@sigmaprime.io>
Co-authored-by: Michael Sproul <micsproul@gmail.com>

beacon_node/lighthouse_network/Cargo.toml

@@ -2,47 +2,47 @@
 name = "lighthouse_network"
 version = "0.2.0"
 authors = ["Sigma Prime <contact@sigmaprime.io>"]
-edition = "2021"
+edition = { workspace = true }
 
 [dependencies]
-discv5 = { version = "0.3.1", features = ["libp2p"] }
-unsigned-varint = { version = "0.6.0", features = ["codec"] }
-types = { path =  "../../consensus/types" }
-ssz_types = "0.5.3"
-serde = { version = "1.0.116", features = ["derive"] }
-serde_derive = "1.0.116"
-ethereum_ssz = "0.5.0"
-ethereum_ssz_derive = "0.5.0"
-tree_hash = "0.5.0"
-tree_hash_derive = "0.5.0"
-slog = { version = "2.5.2", features = ["max_level_trace"] }
-lighthouse_version = { path = "../../common/lighthouse_version" }
-tokio = { version = "1.14.0", features = ["time", "macros"] }
-futures = "0.3.7"
-error-chain = "0.12.4"
-dirs = "3.0.1"
-fnv = "1.0.7"
-lazy_static = "1.4.0"
-lighthouse_metrics = { path = "../../common/lighthouse_metrics" }
-smallvec = "1.6.1"
-tokio-io-timeout = "1.1.1"
-lru = "0.7.1"
-lru_cache = { path = "../../common/lru_cache" }
-parking_lot = "0.12.0"
-sha2 = "0.10"
-snap = "1.0.1"
-hex = "0.4.2"
-tokio-util = { version = "0.6.2", features = ["codec", "compat", "time"] }
-tiny-keccak = "2.0.2"
-task_executor = { path = "../../common/task_executor" }
-rand = "0.8.5"
-directory = { path = "../../common/directory" }
-regex = "1.5.5"
-strum = { version = "0.24.0", features = ["derive"] }
-superstruct = "0.5.0"
+discv5 = { workspace = true }
+unsigned-varint = { version = "0.6", features = ["codec"] }
+ssz_types = { workspace = true }
+types = { workspace = true }
+serde = { workspace = true }
+serde_derive = "1"
+ethereum_ssz = { workspace = true }
+ethereum_ssz_derive = { workspace = true }
+tree_hash = { workspace = true }
+tree_hash_derive = { workspace = true }
+slog = { workspace = true }
+lighthouse_version = { workspace = true }
+tokio = { workspace = true }
+futures = { workspace = true }
+error-chain = { workspace = true }
+dirs = { workspace = true }
+fnv = { workspace = true }
+lazy_static = { workspace = true }
+lighthouse_metrics = { workspace = true }
+smallvec = { workspace = true }
+tokio-io-timeout = "1"
+lru = { workspace = true }
+lru_cache = { workspace = true }
+parking_lot = { workspace = true }
+sha2 = { workspace = true }
+snap = { workspace = true }
+hex = { workspace = true }
+tokio-util = { workspace = true }
+tiny-keccak = "2"
+task_executor = { workspace = true }
+rand = { workspace = true }
+directory = { workspace = true }
+regex = { workspace = true }
+strum = { workspace = true }
+superstruct = { workspace = true }
 prometheus-client = "0.21.0"
-unused_port = { path = "../../common/unused_port" }
-delay_map = "0.3.0"
+unused_port = { workspace = true }
+delay_map = { workspace = true }
 void = "1"
 libp2p-quic= { version = "0.9.2", features=["tokio"]}
 libp2p-mplex = "0.40.0"
@@ -53,10 +53,13 @@ default-features = false
 features = ["identify", "yamux", "noise", "gossipsub", "dns", "tcp", "tokio", "plaintext", "secp256k1", "macros", "ecdsa"]
 
 [dev-dependencies]
-slog-term = "2.6.0"
-slog-async = "2.5.0"
-tempfile = "3.1.0"
-exit-future = "0.2.0"
-void = "1"
-quickcheck = "0.9.2"
-quickcheck_macros = "0.9.1"
+slog-term = { workspace = true }
+slog-async = { workspace = true }
+tempfile = { workspace = true }
+exit-future = { workspace = true }
+quickcheck = { workspace = true }
+quickcheck_macros = { workspace = true }
+
+[features]
+libp2p-websocket = []
+

beacon_node/lighthouse_network/src/config.rs

@@ -453,7 +453,7 @@ pub fn gossipsub_config(
     // We use the first 8 bytes of SHA256(topic, data) for content addressing
     let fast_gossip_message_id = |message: &gossipsub::RawMessage| {
         let data = [message.topic.as_str().as_bytes(), &message.data].concat();
-        gossipsub::FastMessageId::from(&Sha256::digest(data)[..8])
+        gossipsub::FastMessageId::from(&Sha256::digest(&data)[..8])
     };
     fn prefix(
         prefix: [u8; 4],

beacon_node/lighthouse_network/src/peer_manager/mod.rs

@@ -2197,7 +2197,7 @@ mod tests {
         }
 
         impl Arbitrary for PeerCondition {
-            fn arbitrary<G: Gen>(g: &mut G) -> Self {
+            fn arbitrary(g: &mut Gen) -> Self {
                 let attestation_net_bitfield = {
                     let len = <E as EthSpec>::SubnetBitfieldLength::to_usize();
                     let mut bitfield = Vec::with_capacity(len);