gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-07 16:55:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefix VC root spans with lh_ so they get exported to tracing backend (#9129)

Browse Source 
The tracing exporter uses a `PrefixBasedSampler` that only samples root spans whose name starts with `lh_`. Rename the VC root spans to include the prefix so their traces are exported.

Thanks @lmnzx for pointing this out!


  


Co-Authored-By: Jimmy Chen <jchen.tc@gmail.com>
This commit is contained in:
Jimmy Chen
2026-04-16 10:07:58 +10:00
committed by GitHub
parent 30446b9f3a
commit e0922badbe
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
validator_client/validator_services/src/attestation_service.rs
View File

@@ -439,7 +439,7 @@ impl<S: ValidatorStore + 'static, T: SlotClock + 'static> AttestationService<S,
} }
#[instrument( #[instrument(
name = "handle_aggregates", name = "lh_handle_aggregates",
skip_all, skip_all,
fields(%slot, %committee_index) fields(%slot, %committee_index)
)] )]
@@ -494,7 +494,7 @@ impl<S: ValidatorStore + 'static, T: SlotClock + 'static> AttestationService<S,
/// ///
/// The given `validator_duties` should already be filtered to only contain those that match /// The given `validator_duties` should already be filtered to only contain those that match
/// `slot`. Critical errors will be logged if this is not the case. /// `slot`. Critical errors will be logged if this is not the case.
#[instrument(skip_all, fields(%slot, %attestation_data.beacon_block_root))] #[instrument(name = "lh_sign_and_publish_attestations", skip_all, fields(%slot, %attestation_data.beacon_block_root))]
async fn sign_and_publish_attestations( async fn sign_and_publish_attestations(
&self, &self,
slot: Slot, slot: Slot,

2
validator_client/validator_services/src/block_service.rs
View File

@@ -404,7 +404,7 @@ impl<S: ValidatorStore + 'static, T: SlotClock + 'static> BlockService<S, T> {
} }
#[instrument( #[instrument(
name = "block_proposal_duty_cycle", name = "lh_block_proposal_duty_cycle",
skip_all, skip_all,
fields(%slot, ?validator_pubkey) fields(%slot, ?validator_pubkey)
)] )]

6
validator_client/validator_services/src/sync_committee_service.rs
View File

@@ -214,7 +214,7 @@ impl<S: ValidatorStore + 'static, T: SlotClock + 'static> SyncCommitteeService<S
.map(|_| ()) .map(|_| ())
.await .await
} }
.instrument(info_span!("sync_committee_signature_publish", %slot)), .instrument(info_span!("lh_sync_committee_signature_publish", %slot)),
"sync_committee_signature_publish", "sync_committee_signature_publish",
); );
@@ -232,7 +232,7 @@ impl<S: ValidatorStore + 'static, T: SlotClock + 'static> SyncCommitteeService<S
.map(|_| ()) .map(|_| ())
.await .await
} }
.instrument(info_span!("sync_committee_aggregate_publish", %slot)), .instrument(info_span!("lh_sync_committee_aggregate_publish", %slot)),
"sync_committee_aggregate_publish", "sync_committee_aggregate_publish",
); );
@@ -324,7 +324,7 @@ impl<S: ValidatorStore + 'static, T: SlotClock + 'static> SyncCommitteeService<S
.map(|_| ()) .map(|_| ())
.await .await
} }
.instrument(info_span!("publish_sync_committee_aggregate_for_subnet", %slot, ?beacon_block_root, %subnet_id)), .instrument(info_span!("lh_publish_sync_committee_aggregate_for_subnet", %slot, ?beacon_block_root, %subnet_id)),
"sync_committee_aggregate_publish_subnet", "sync_committee_aggregate_publish_subnet",
); );
} }