gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-08 17:26:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce big-O complexity of address change pruning

Browse Source 
I'm not sure this is *actually* useful, but it might come in handy if we see a
ton of address changes at the fork boundary. I know the devops team have been
testing with ~100k changes, so maybe this will help in that case.
This commit is contained in:
Paul Hauner
2023-02-21 12:11:14 +11:00
parent 110f853715
commit e7d93e6cc7
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
beacon_node/operation_pool/src/bls_to_execution_changes.rs
View File

@@ -106,6 +106,16 @@ impl<T: EthSpec> BlsToExecutionChanges<T> {
spec: &ChainSpec, spec: &ChainSpec,
) { ) {
let mut validator_indices_pruned = vec![]; let mut validator_indices_pruned = vec![];
let recently_changed_indices: HashSet<u64> = head_block
.message()
.body()
.bls_to_execution_changes()
.map_or(HashSet::default(), |recent_changes| {
recent_changes
.iter()
.map(|c| c.message.validator_index)
.collect()
});
self.queue.retain(|address_change| { self.queue.retain(|address_change| {
let validator_index = address_change.as_inner().message.validator_index; let validator_index = address_change.as_inner().message.validator_index;
@@ -114,15 +124,7 @@ impl<T: EthSpec> BlsToExecutionChanges<T> {
.get(validator_index as usize) .get(validator_index as usize)
.map_or(true, |validator| { .map_or(true, |validator| {
let prune = validator.has_eth1_withdrawal_credential(spec) let prune = validator.has_eth1_withdrawal_credential(spec)
&& head_block && !recently_changed_indices.contains(&validator_index);
.message()
.body()
.bls_to_execution_changes()
.map_or(true, |recent_changes| {
!recent_changes
.iter()
.any(|c| c.message.validator_index == validator_index)
});
if prune { if prune {
validator_indices_pruned.push(validator_index); validator_indices_pruned.push(validator_index);
} }