O(n) children index, fix load_parent for gloas blocks

- Build parent->children index once per find_head call, replacing O(n)
  scans in filter_block_tree and get_node_children with O(1) lookups.
- Skip zero block_hash in is_parent_block_full check — default/zero
  hashes don't indicate a real payload relationship.
- Fall back to block state_root for genesis when envelope not stored.
- Store execution payload envelope in EF test harness during
  on_execution_payload step.
This commit is contained in:
dapplion
2026-03-25 19:36:14 -05:00
parent d58df3a656
commit e7f027badd
3 changed files with 88 additions and 35 deletions

View File

@@ -1964,15 +1964,27 @@ fn load_parent<T: BeaconChainTypes, B: AsBlock<T::EthSpec>>(
if block.as_block().fork_name_unchecked().gloas_enabled()
&& let Ok(parent_bid_block_hash) = parent_block.payload_bid_block_hash()
{
if block.as_block().is_parent_block_full(parent_bid_block_hash) {
if !parent_bid_block_hash.into_root().is_zero()
&& block.as_block().is_parent_block_full(parent_bid_block_hash)
{
// TODO(gloas): loading the envelope here is not very efficient
// TODO(gloas): check parent payload existence prior to this point?
let envelope = chain.store.get_payload_envelope(&root)?.ok_or_else(|| {
BeaconChainError::DBInconsistent(format!(
"Missing envelope for parent block {root:?}",
))
})?;
(StatePayloadStatus::Full, envelope.message.state_root)
let envelope = chain.store.get_payload_envelope(&root)?;
let state_root = if let Some(env) = envelope {
env.message.state_root
} else {
// The envelope may not be stored yet for the genesis/anchor
// block. Fall back to the block's state_root which is the
// post-payload state for the anchor per get_forkchoice_store.
if parent_block.slot() == chain.spec.genesis_slot {
parent_block.state_root()
} else {
return Err(BeaconChainError::DBInconsistent(format!(
"Missing envelope for parent block {root:?}",
))
.into());
}
};
(StatePayloadStatus::Full, state_root)
} else {
(StatePayloadStatus::Pending, parent_block.state_root())
}