Implement PartialOrd for ForkName

consensus/types/src/fork_name.rs

@@ -1,12 +1,12 @@
+use crate::fork_order::FORK_ORDER;
 use crate::{ChainSpec, Epoch};
 use serde::{Deserialize, Serialize};
 use ssz_derive::{Decode, Encode};
+use std::cmp::{Ord, Ordering};
 use std::fmt::{self, Display, Formatter};
 use std::str::FromStr;
 
-#[derive(
+#[derive(Debug, Clone, Copy, Decode, Encode, PartialEq, Eq, Hash, Serialize, Deserialize)]
-    Debug, Clone, Copy, Decode, Encode, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize,
-)]
 #[serde(try_from = "String")]
 #[serde(into = "String")]
 #[ssz(enum_behaviour = "tag")]
@@ -19,21 +19,34 @@ pub enum ForkName {
     Electra,
 }
 
+impl PartialOrd for ForkName {
+    fn partial_cmp(&self, other: &ForkName) -> Option<Ordering> {
+        let self_idx = FORK_ORDER
+            .iter()
+            .position(|(fork_name, _)| fork_name == self);
+        let other_idx = FORK_ORDER
+            .iter()
+            .position(|(fork_name, _)| fork_name == other);
+
+        // Forks that are not enabled will come back as `None`. Treat them as greater than all
+        // enabled forks (and equal to each other).
+        match (self_idx, other_idx) {
+            (None, None) => None, // incomparable
+            (None, Some(_)) => Some(Ordering::Greater),
+            (Some(_), None) => Some(Ordering::Less),
+            (Some(i), Some(j)) => Some(i.cmp(&j)),
+        }
+    }
+}
+
 impl ForkName {
     pub fn list_all() -> Vec<ForkName> {
-        vec![
+        FORK_ORDER.iter().map(|(fork, _)| *fork).collect()
-            ForkName::Base,
-            ForkName::Altair,
-            ForkName::Merge,
-            ForkName::Capella,
-            ForkName::Deneb,
-            ForkName::Electra,
-        ]
     }
 
-    pub fn latest() -> ForkName {
+    pub const fn latest() -> ForkName {
-        // This unwrap is safe as long as we have 1+ forks. It is tested below.
+        #[allow(clippy::arithmetic_side_effects, clippy::indexing_slicing)]
-        *ForkName::list_all().last().unwrap()
+        FORK_ORDER[FORK_ORDER.len() - 1].0
     }
 
     /// Set the activation slots in the given `ChainSpec` so that the fork named by `self`

consensus/types/src/fork_order.rs

@@ -18,3 +18,18 @@ pub const FEATURE_DEPENDENCIES: &[(FeatureName, &[FeatureName])] = &[
     (FeatureName::Withdrawals, &[FeatureName::Merge]),
     (FeatureName::Blobs, &[FeatureName::Withdrawals]),
 ];
+
+#[cfg(test)]
+mod test {
+    use super::*;
+    use itertools::Itertools;
+
+    #[test]
+    fn partial_ord_sanity_check() {
+        for (fork_a, fork_b) in FORK_ORDER.iter().map(|(fork, _)| fork).tuple_windows() {
+            assert!(fork_a < fork_b, "{fork_a} < {fork_b}");
+            assert_eq!(fork_a, fork_a);
+            assert_eq!(fork_b, fork_b);
+        }
+    }
+}