gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-02 16:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fullnodes to publish data columns from EL getBlobs (#7258)

Browse Source 
Previously only supernode contributes to data column publishing in Lighthouse.

Recently we've [updated the spec](https://github.com/ethereum/consensus-specs/pull/4183) to have full nodes publishing data columns as well, to ensure all nodes contributes to propagation.

This also prevents already imported data columns from being imported again (because we don't "observe" them), and ensures columns that are observed in the [gossip seen cache](d60c24ef1c/beacon_node/beacon_chain/src/data_column_verification.rs (L492)) are forwarded to its peers, rather than being ignored.
This commit is contained in:
Jimmy Chen
2025-04-08 13:20:31 +10:00
committed by GitHub
parent 47a85cd118
commit e924264e17
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
beacon_node/network/src/network_beacon_processor/mod.rs
View File

@@ -843,19 +843,19 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
block_root: Hash256,
publish_blobs: bool,
) {
let custody_columns = self.network_globals.sampling_columns.clone();
let is_supernode = self.network_globals.is_supernode();
let self_cloned = self.clone();
let publish_fn = move |blobs_or_data_column| {
// At the moment non supernodes are not required to publish any columns.
// TODO(das): we could experiment with having full nodes publish their custodied
// columns here.
if publish_blobs && is_supernode {
if publish_blobs {
match blobs_or_data_column {
BlobsOrDataColumns::Blobs(blobs) => {
self_cloned.publish_blobs_gradually(blobs, block_root);
}
BlobsOrDataColumns::DataColumns(columns) => {
BlobsOrDataColumns::DataColumns(mut columns) => {
if !is_supernode {
columns.retain(|col| custody_columns.contains(&col.index));
}
self_cloned.publish_data_columns_gradually(columns, block_root);
}
};
@@ -1055,7 +1055,7 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
///
/// This is an optimisation to reduce outbound bandwidth and ensures each column is published
/// by some nodes on the network as soon as possible. Our hope is that some columns arrive from
/// other supernodes in the meantime, obviating the need for us to publish them. If no other
/// other nodes in the meantime, obviating the need for us to publish them. If no other
/// publisher exists for a column, it will eventually get published here.
fn publish_data_columns_gradually(
self: &Arc<Self>,
@@ -1080,9 +1080,9 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
});
};
// If this node is a super node, permute the columns and split them into batches.
// Permute the columns and split them into batches.
// The hope is that we won't need to publish some columns because we will receive them
// on gossip from other supernodes.
// on gossip from other nodes.
data_columns_to_publish.shuffle(&mut rand::thread_rng());
let blob_publication_batch_interval = chain.config.blob_publication_batch_interval;