gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-07 00:42:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address code review feedback

Browse Source 
- Fix comment about available time computation to reflect actual implementation
- Use current time for reconstructed column timestamps instead of max partial timestamp

Co-authored-by: michaelsproul <4452260+michaelsproul@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-09 21:20:34 +00:00
parent 8debf97d3d
commit ebb8bea461
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
beacon_node/beacon_chain/src/block_times_cache.rs
View File

@@ -43,7 +43,7 @@ pub struct BlockDelays {
pub execution_time: Option<Duration>, pub execution_time: Option<Duration>,
/// The delay from the start of the slot before the block became available /// The delay from the start of the slot before the block became available
/// ///
/// Equal to max(`observed + execution_time`, `all_blobs_observed` or `all_data_columns_observed`). /// Equal to max(`executed`, `all_blobs_observed` or `all_data_columns_observed`) minus slot start time.
pub available: Option<Duration>, pub available: Option<Duration>,
/// Time after `available`. /// Time after `available`.
pub attestable: Option<Duration>, pub attestable: Option<Duration>,

12
beacon_node/beacon_chain/src/data_column_verification.rs
View File

@@ -16,7 +16,7 @@ use ssz_types::VariableList;
use std::iter; use std::iter;
use std::marker::PhantomData; use std::marker::PhantomData;
use std::sync::Arc; use std::sync::Arc;
use std::time::Duration; use std::time::{Duration, SystemTime, UNIX_EPOCH};
use tracing::{debug, instrument}; use tracing::{debug, instrument};
use types::data::ColumnIndex; use types::data::ColumnIndex;
use types::{ use types::{
@@ -475,12 +475,10 @@ impl<E: EthSpec> KzgVerifiedCustodyDataColumn<E> {
spec, spec,
)?; )?;
// Use the maximum timestamp from the partial set for reconstructed columns // Use the current time as the seen_timestamp for reconstructed columns
let seen_timestamp = partial_set_of_columns let seen_timestamp = SystemTime::now()
.iter() .duration_since(UNIX_EPOCH)
.map(|col| col.seen_timestamp) .unwrap_or_else(|_| Duration::from_secs(0));
.max()
.unwrap_or_default();
Ok(all_data_columns Ok(all_data_columns
.into_iter() .into_iter()