From ebd661783e24894e35c334c66fc2dc1e8f7b3bb9 Mon Sep 17 00:00:00 2001 From: Paul Hauner Date: Wed, 24 Aug 2022 23:34:59 +0000 Subject: [PATCH] Enable `block_lookup_failed` EF test (#3489) ## Issue Addressed Resolves #3448 ## Proposed Changes Removes a known failure that wasn't actually a known failure. The tests declare this block invalid and we refuse to import it due to `ExecutionPayloadError(UnverifiedNonOptimisticCandidate)`. This is correct since there is only one "eth1" block included in this test and two are required to trigger the merge (pre- and post-TTD blocks). It is slot 1 (tick = 12s) when this block is imported so the import must be prevented by `SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY`. I'm not sure where I got the idea in #3448 that this test needed retrospective checking, that seems like a false assumption in hindsight. ## Additional Info - Blocked on #3464 --- testing/ef_tests/src/cases/fork_choice.rs | 7 ------- 1 file changed, 7 deletions(-) diff --git a/testing/ef_tests/src/cases/fork_choice.rs b/testing/ef_tests/src/cases/fork_choice.rs index 9efb7ada12..650452d783 100644 --- a/testing/ef_tests/src/cases/fork_choice.rs +++ b/testing/ef_tests/src/cases/fork_choice.rs @@ -156,13 +156,6 @@ impl Case for ForkChoiceTest { fn result(&self, _case_index: usize, fork_name: ForkName) -> Result<(), Error> { let tester = Tester::new(self, testing_spec::(fork_name))?; - // TODO(merge): re-enable this test before production. - // This test is skipped until we can do retrospective confirmations of the terminal - // block after an optimistic sync. - if self.description == "block_lookup_failed" { - return Err(Error::SkippedKnownFailure); - }; - for step in &self.steps { match step { Step::Tick { tick } => tester.set_tick(*tick),