gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-20 05:14:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bound lookup parent chain length with tip extension (#5705)

Browse Source 
* Bound lookup parent chain length with tip extension

* Add test
This commit is contained in:
Lion - dapplion
2024-06-27 20:21:37 +02:00
committed by GitHub
parent 9b093c8459
commit f14f21f37b
2 changed files with 51 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
beacon_node/network/src/sync/block_lookups/mod.rs
View File

@@ -194,7 +194,15 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
let parent_chains = self.active_parent_lookups();
for (chain_idx, parent_chain) in parent_chains.iter().enumerate() {
if parent_chain.ancestor() == child_block_root_trigger
// `block_root_to_search` will trigger a new lookup, and it will extend a parent_chain
// beyond its max length
let block_would_extend_chain = parent_chain.ancestor() == child_block_root_trigger;
// `block_root_to_search` already has a lookup, and with the block trigger it extends
// the parent_chain beyond its length. This can happen because when creating a lookup
// for a new root we don't do any parent chain length checks
let trigger_is_chain_tip = parent_chain.tip == child_block_root_trigger;
if (block_would_extend_chain || trigger_is_chain_tip)
&& parent_chain.len() >= PARENT_DEPTH_TOLERANCE
{
debug!(self.log, "Parent lookup chain too long"; "block_root" => ?block_root_to_search);
@@ -375,6 +383,14 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
"response_type" => ?response_type,
);
// Here we could check if response extends a parent chain beyond its max length.
// However we defer that check to the handling of a processing error ParentUnknown.
//
// Here we could check if there's already a lookup for parent_root of `response`. In
// that case we know that sending the response for processing will likely result in
// a `ParentUnknown` error. However, for simplicity we choose to not implement this
// optimization.
// Register the download peer here. Once we have received some data over the wire we
// attribute it to this peer for scoring latter regardless of how the request was
// done.