mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-09 11:41:51 +00:00
Remove consensus/types re-exports (#8540)
There are certain crates which we re-export within `types` which creates a fragmented DevEx, where there are various ways to import the same crates.
```rust
// consensus/types/src/lib.rs
pub use bls::{
AggregatePublicKey, AggregateSignature, Error as BlsError, Keypair, PUBLIC_KEY_BYTES_LEN,
PublicKey, PublicKeyBytes, SIGNATURE_BYTES_LEN, SecretKey, Signature, SignatureBytes,
get_withdrawal_credentials,
};
pub use context_deserialize::{ContextDeserialize, context_deserialize};
pub use fixed_bytes::FixedBytesExtended;
pub use milhouse::{self, List, Vector};
pub use ssz_types::{BitList, BitVector, FixedVector, VariableList, typenum, typenum::Unsigned};
pub use superstruct::superstruct;
```
This PR removes these re-exports and makes it explicit that these types are imported from a non-`consensus/types` crate.
Co-Authored-By: Mac L <mjladson@pm.me>
This commit is contained in:
@@ -1,9 +1,11 @@
|
||||
use bls::PublicKeyBytes;
|
||||
use context_deserialize::ContextDeserialize;
|
||||
pub use eth2::Error;
|
||||
use eth2::types::beacon_response::EmptyMetadata;
|
||||
use eth2::types::builder_bid::SignedBuilderBid;
|
||||
use eth2::types::{
|
||||
ContentType, ContextDeserialize, EthSpec, ExecutionBlockHash, ForkName, ForkVersionDecode,
|
||||
ForkVersionedResponse, PublicKeyBytes, SignedValidatorRegistrationData, Slot,
|
||||
ContentType, EthSpec, ExecutionBlockHash, ForkName, ForkVersionDecode, ForkVersionedResponse,
|
||||
SignedValidatorRegistrationData, Slot,
|
||||
};
|
||||
use eth2::types::{FullPayloadContents, SignedBlindedBeaconBlock};
|
||||
use eth2::{
|
||||
@@ -538,9 +540,10 @@ impl BuilderHttpClient {
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
use bls::Signature;
|
||||
use eth2::types::MainnetEthSpec;
|
||||
use eth2::types::builder_bid::{BuilderBid, BuilderBidFulu};
|
||||
use eth2::types::test_utils::{SeedableRng, TestRandom, XorShiftRng};
|
||||
use eth2::types::{MainnetEthSpec, Signature};
|
||||
use mockito::{Matcher, Server, ServerGuard};
|
||||
|
||||
type E = MainnetEthSpec;
|
||||
|
||||
Reference in New Issue
Block a user