mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-15 02:42:38 +00:00
Remove consensus/types re-exports (#8540)
There are certain crates which we re-export within `types` which creates a fragmented DevEx, where there are various ways to import the same crates.
```rust
// consensus/types/src/lib.rs
pub use bls::{
AggregatePublicKey, AggregateSignature, Error as BlsError, Keypair, PUBLIC_KEY_BYTES_LEN,
PublicKey, PublicKeyBytes, SIGNATURE_BYTES_LEN, SecretKey, Signature, SignatureBytes,
get_withdrawal_credentials,
};
pub use context_deserialize::{ContextDeserialize, context_deserialize};
pub use fixed_bytes::FixedBytesExtended;
pub use milhouse::{self, List, Vector};
pub use ssz_types::{BitList, BitVector, FixedVector, VariableList, typenum, typenum::Unsigned};
pub use superstruct::superstruct;
```
This PR removes these re-exports and makes it explicit that these types are imported from a non-`consensus/types` crate.
Co-Authored-By: Mac L <mjladson@pm.me>
This commit is contained in:
@@ -19,10 +19,11 @@ pub use crate::slashing_database::{
|
||||
InterchangeError, InterchangeImportOutcome, SUPPORTED_INTERCHANGE_FORMAT_VERSION,
|
||||
SlashingDatabase,
|
||||
};
|
||||
use bls::PublicKeyBytes;
|
||||
use rusqlite::Error as SQLError;
|
||||
use std::fmt::Display;
|
||||
use std::io::{Error as IOError, ErrorKind};
|
||||
use types::{Hash256, PublicKeyBytes};
|
||||
use types::Hash256;
|
||||
|
||||
/// The filename within the `validators` directory that contains the slashing protection DB.
|
||||
pub const SLASHING_PROTECTION_FILENAME: &str = "slashing_protection.sqlite";
|
||||
@@ -133,7 +134,7 @@ impl Display for NotSafe {
|
||||
|
||||
#[cfg(test)]
|
||||
mod test {
|
||||
use types::FixedBytesExtended;
|
||||
use fixed_bytes::FixedBytesExtended;
|
||||
|
||||
use super::*;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user