gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-09 03:17:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update proposer boost calculation (#9215)

Browse Source 
Closes:

- https://github.com/sigp/lighthouse/issues/8689


  - Calculate the proposer index on the canonical chain (from canonical head) at `slot` and plumb it through to fork choice so it can be used to determine whether or not to apply the proposer boost. We use the proposer cache to handle state advances and avoid duplicate work.
- Update our FC tests to use `block.message().proposer_index()` (always pass), we are not attempting to test this feature in those tests. The EF tests use the correct canonical proposer idnex via `on_block`, except for invalid blocks which just auto-pass this check (these blocks get rejected by other checks in `on_block` anyway).


Co-Authored-By: Michael Sproul <michael@sigmaprime.io>
This commit is contained in:
Michael Sproul
2026-04-29 22:19:44 +10:00
committed by GitHub
parent 0e427ab77b
commit f406e9c3fb
6 changed files with 79 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
beacon_node/http_api/tests/tests.rs
View File

@@ -3450,17 +3450,20 @@ impl ApiTester {
.unwrap()
.unwrap_or(self.chain.head_beacon_block_root());
// Presently, the beacon chain harness never runs the code that primes the proposer
// cache. If this changes in the future then we'll need some smarter logic here, but
// this is succinct and effective for the time being.
assert!(
self.chain
.beacon_proposer_cache
.lock()
.get_epoch::<E>(dependent_root, epoch)
.is_none(),
"the proposer cache should miss initially"
);
// Block import primes the proposer cache for each epoch it runs through (to gate
// proposer boost), so epochs `<= current_epoch` are already cached. The only epoch
// for which we can observe the endpoint's own caching behaviour is
// `current_epoch + 1`, which no block import has touched yet.
if epoch == current_epoch + 1 {
assert!(
self.chain
.beacon_proposer_cache
.lock()
.get_epoch::<E>(dependent_root, epoch)
.is_none(),
"the proposer cache should miss initially for the next epoch"
);
}
let result = self
.client
@@ -3468,8 +3471,9 @@ impl ApiTester {
.await
.unwrap();
// Check that current-epoch requests prime the proposer cache, whilst non-current
// requests don't.
// A current-epoch request should leave the cache primed (block import already did so,
// but this is still a useful end-to-end check). A request for `current_epoch + 1`
// should not prime the cache.
if epoch == current_epoch {
assert!(
self.chain
@@ -3477,16 +3481,16 @@ impl ApiTester {
.lock()
.get_epoch::<E>(dependent_root, epoch)
.is_some(),
"a current-epoch request should prime the proposer cache"
"the proposer cache should be primed for the current epoch"
);
} else {
} else if epoch == current_epoch + 1 {
assert!(
self.chain
.beacon_proposer_cache
.lock()
.get_epoch::<E>(dependent_root, epoch)
.is_none(),
"a non-current-epoch request should not prime the proposer cache"
"a request for the next epoch should not prime the proposer cache"
);
}