gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-30 12:47:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Dont penalize payload envelope peers after gossip verification (#9283)

Browse Source 
We got in a little bit of trouble in devnet-3. After gossip verifying an envelope and before importing it, we got the following error

```
May 07 08:04:24.383 WARN  Execution payload envelope rejected           reason: "EnvelopeProcessingError(WithdrawalsRootMismatch { state: 0x852d38aaecc9f4e2e309919f74020c7bbcf050fea4a20edf3304f171e44ee9d5, payload:
```

The envelope had already passed gossip verification checks and was correctly propagated to the network, we should not penalize peers for doing this. This caused our node to isolate itself from the rest of the network. This PR removes peer penalties for any envelope that passes gossip validation


  


Co-Authored-By: Eitan Seri-Levi <eserilev@ucsc.edu>
This commit is contained in:
Eitan Seri-Levi
2026-05-12 04:59:54 +03:00
committed by GitHub
parent 2208e17937
commit f968c7e5bb
1 changed files with 7 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
beacon_node/network/src/network_beacon_processor/gossip_methods.rs
View File

@@ -3977,44 +3977,13 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
// TODO(gloas) metrics
// register_process_result_metrics(&result, metrics::BlockSource::Gossip, "envelope");
match &result {
Ok(AvailabilityProcessingStatus::Imported(_))
| Ok(AvailabilityProcessingStatus::MissingComponents(_, _)) => {
// Nothing to do
}
Err(e) => match e {
EnvelopeError::ExecutionPayloadError(epe) if !epe.penalize_peer() => {}
EnvelopeError::BadSignature
| EnvelopeError::BuilderIndexMismatch { .. }
| EnvelopeError::SlotMismatch { .. }
| EnvelopeError::BlockHashMismatch { .. }
| EnvelopeError::UnknownValidator { .. }
| EnvelopeError::IncorrectBlockProposer { .. }
| EnvelopeError::ExecutionPayloadError(_) => {
self.gossip_penalize_peer(
peer_id,
PeerAction::LowToleranceError,
"gossip_envelope_processing_low",
);
}
EnvelopeError::EnvelopeProcessingError(_)
| EnvelopeError::BlockError(_)
| EnvelopeError::BlockRootUnknown { .. } => {
self.gossip_penalize_peer(
peer_id,
PeerAction::LowToleranceError,
"gossip_envelope_processing_error",
);
}
EnvelopeError::PriorToFinalization { .. }
| EnvelopeError::OptimisticSyncNotSupported { .. }
| EnvelopeError::BeaconChainError(_)
| EnvelopeError::BeaconStateError(_)
| EnvelopeError::BlockProcessingError(_)
| EnvelopeError::InternalError(_) => {}
},
if let Err(e) = &result {
debug!(
?beacon_block_root,
%peer_id,
error = ?e,
"Execution payload envelope processing failed"
);
}
}