From f9f6161a7af9b89e2a95353725a384a5232342b4 Mon Sep 17 00:00:00 2001 From: Paul Hauner Date: Wed, 22 May 2019 14:18:48 +1000 Subject: [PATCH] Ensure ef_tests run with the right fake_crypto cfg --- tests/ef_tests/src/doc.rs | 9 +++++---- tests/ef_tests/tests/tests.rs | 3 +++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/ef_tests/src/doc.rs b/tests/ef_tests/src/doc.rs index 8c4598d63d..d10f8e9357 100644 --- a/tests/ef_tests/src/doc.rs +++ b/tests/ef_tests/src/doc.rs @@ -51,10 +51,11 @@ impl Doc { ("bls", "msg_hash_compressed", "mainnet") => { run_test::(self) } - ("bls", "msg_hash_uncompressed", "mainnet") => { - // Note this test fails but Not due to a bug - vec![] // run_test::(&self.yaml) - } + // Note this test fails due to a difference in our internal representations. It does + // not effect verification or external representation. + // + // It is skipped. + ("bls", "msg_hash_uncompressed", "mainnet") => vec![], ("bls", "priv_to_pub", "mainnet") => run_test::(self), ("bls", "sign_msg", "mainnet") => run_test::(self), (runner, handler, config) => panic!( diff --git a/tests/ef_tests/tests/tests.rs b/tests/ef_tests/tests/tests.rs index a52e3757ac..def180c025 100644 --- a/tests/ef_tests/tests/tests.rs +++ b/tests/ef_tests/tests/tests.rs @@ -27,6 +27,7 @@ fn yaml_files_in_test_dir(dir: &str) -> Vec { } #[test] +#[cfg(feature = "fake_crypto")] fn ssz_generic() { yaml_files_in_test_dir("ssz_generic") .into_par_iter() @@ -36,6 +37,7 @@ fn ssz_generic() { } #[test] +#[cfg(feature = "fake_crypto")] fn ssz_static() { yaml_files_in_test_dir("ssz_static") .into_par_iter() @@ -45,6 +47,7 @@ fn ssz_static() { } #[test] +#[cfg(not(feature = "fake_crypto"))] fn bls() { yaml_files_in_test_dir("bls") .into_par_iter()