Revert "Reuse milhouse subtrees to shrink inactivity_scores in memory (#7062)"

This reverts commit 6399ad482b.

beacon_node/beacon_chain/src/test_utils.rs

@@ -2713,16 +2713,16 @@ where
         let mut block_hash_from_slot: HashMap<Slot, SignedBeaconBlockHash> = HashMap::new();
         let mut state_hash_from_slot: HashMap<Slot, BeaconStateHash> = HashMap::new();
         for slot in slots {
-            // Using a `Box::pin` to reduce the stack size. Clippy was raising a lints.
-            let (block_hash, new_state) = Box::pin(self.add_attested_block_at_slot_with_sync(
-                *slot,
-                state,
-                state_root,
-                validators,
-                sync_committee_strategy,
-            ))
-            .await
-            .unwrap();
+            let (block_hash, new_state) = self
+                .add_attested_block_at_slot_with_sync(
+                    *slot,
+                    state,
+                    state_root,
+                    validators,
+                    sync_committee_strategy,
+                )
+                .await
+                .unwrap();
 
             state = new_state;
 

beacon_node/beacon_chain/tests/rewards.rs

@@ -328,7 +328,8 @@ async fn test_rewards_base_multi_inclusion() {
         .extend_slots(E::slots_per_epoch() as usize * 2 - 4)
         .await;
 
-    check_all_base_rewards(&harness, initial_balances).await;
+    // pin to reduce stack size for clippy
+    Box::pin(check_all_base_rewards(&harness, initial_balances)).await;
 }
 
 #[tokio::test]
@@ -691,8 +692,7 @@ async fn check_all_base_rewards(
     harness: &BeaconChainHarness<EphemeralHarnessType<E>>,
     balances: Vec<u64>,
 ) {
-    // The box reduces the size on the stack for a clippy lint.
-    Box::pin(check_all_base_rewards_for_subset(harness, balances, vec![])).await;
+    check_all_base_rewards_for_subset(harness, balances, vec![]).await;
 }
 
 async fn check_all_base_rewards_for_subset(