Commit Graph

2546 Commits

Author SHA1 Message Date
Pawan Dhananjay
0958ce610f lint 2023-03-21 00:46:34 +05:30
Pawan Dhananjay
38f2b88dd0 Merge branch 'deneb-free-blobs' into partial-processing 2023-03-20 22:37:07 +05:30
Pawan Dhananjay
8e2633bf66 Merge branch 'too-many-blob-branches' into partial-processing 2023-03-20 22:00:32 +05:30
Pawan Dhananjay
463ce3d1fe Remove reprocessing cache stuff 2023-03-20 21:21:48 +05:30
Pawan Dhananjay
3c1687d23c Merge stuff 2023-03-20 21:09:02 +05:30
Pawan Dhananjay
c0445e2536 Add sus gossip verification for blobs 2023-03-20 20:28:35 +05:30
Pawan Dhananjay
acd36ccaa6 Reprocess an ExecutedBlock on unavailable blobs 2023-03-20 19:54:08 +05:30
Diva M
78414333a2 Merge branch 'eip4844' into deneb-free-blobs 2023-03-17 16:39:17 -05:00
Diva M
607242c127 Merge branch 'unstable' into eip4844 2023-03-17 16:26:51 -05:00
realbigsean
05db0d2ba3 everything, everywhere, all at once 2023-03-17 16:12:40 -04:00
realbigsean
98babb2e67 Merge branch 'deneb-free-blobs' of https://github.com/sigp/lighthouse into too-many-blob-branches 2023-03-17 09:38:14 -04:00
realbigsean
be4d70eeff tons of changes, just tryna compile 2023-03-16 22:25:04 -04:00
Paul Hauner
020fb483fe Clarify "Ready for Capella" (#4095)
## Issue Addressed

Resolves #4061

## Proposed Changes

Adds a message to tell users to check their EE.

## Additional Info

I really struggled to come up with something succinct and complete, so I'm totally open to feedback.
2023-03-17 00:44:04 +00:00
Paul Hauner
c3e5053612 Reduce false positive logging for late builder blocks (#4073)
## Issue Addressed

NA

## Proposed Changes

When producing a block from a builder, there are two points where we could consider the block "broadcast":

1. When the blinded block is published to the builder.
2. When the un-blinded block is published to the P2P network (this is always *after* the previous step).

Our logging for late block broadcasts was using (2) for builder-blocks, which was creating a lot of false-positive logs. This is because the builder publishes the block on the P2P network themselves before returning it to us and we perform (2). For clarity, the logs were false-positives because we claim that the block was published late by us when it was actually published earlier by the builder.

This PR changes our logging behavior so we do our logging at (1) instead. It also updates our metrics for block broadcast to distinguish between local and builder blocks. I believe the metrics change will be natively compatible with existing Grafana dashboards.

## Additional Info

One could argue that the builder *should* return the block to us faster, however that's not the case. I think it's more important that we don't desensitize users with false-positives.
2023-03-17 00:44:03 +00:00
Michael Sproul
4c2d4af6cd Make more noise when the EL is broken (#3986)
## Issue Addressed

Closes #3814, replaces #3818.

## Proposed Changes

* Add a WARN log for the case where we are attempting to sync chain segments but can't process them because they're building on an invalid parent. The most common case where we see this is when the execution node database is corrupt, causing sync to stall mysteriously (because we're currently logging the failure only at debug level).
* Additionally I've bumped up the logging for invalid execution payloads to `WARN`. This may result in some duplicate logs as we log errors from the `beacon_chain` and then again from the beacon processor. Invalid payloads and corrupt DBs _should_ be rare enough that this doesn't produce overwhelming log volume.
2023-03-17 00:44:02 +00:00
Divma
3c18e1a3a4 thread blocks and blobs to sync (#4100)
* thread blocks and blobs to sync

* satisfy dead code analysis
2023-03-16 19:20:39 -05:00
Pawan Dhananjay
a58c6ed962 more progress 2023-03-16 21:04:22 +05:30
Pawan Dhananjay
9df968c992 more progress 2023-03-16 20:55:21 +05:30
Age Manning
3d99ce25f8 Correct a race condition when dialing peers (#4056)
There is a race condition which occurs when multiple discovery queries return at almost the exact same time and they independently contain a useful peer we would like to connect to.

The condition can occur that we can add the same peer to the dial queue, before we get a chance to process the queue. 
This ends up displaying an error to the user: 
```
ERRO Dialing an already dialing peer
```
Although this error is harmless it's not ideal. 

There are two solutions to resolving this:
1. As we decide to dial the peer, we change the state in the peer-db to dialing (before we add it to the queue) which would prevent other requests from adding to the queue. 
2. We prevent duplicates in the dial queue

This PR has opted for 2. because 1. will complicate the code in that we are changing states in non-intuitive places. Although this technically adds a very slight performance cost, its probably a cleaner solution as we can keep the state-changing logic in one place.
2023-03-16 05:44:54 +00:00
realbigsean
8c79358d35 cargo fmt 2023-03-15 22:18:39 -04:00
realbigsean
4edca9117d extended chaos 2023-03-15 20:24:47 -04:00
realbigsean
c26ce824a0 general chaos 2023-03-15 17:48:22 -04:00
realbigsean
3f3358f8af Merge branch 'deneb-free-blobs' of https://github.com/sigp/lighthouse into sean-blob-blob-blob 2023-03-15 17:34:56 -04:00
realbigsean
73ab4d85d7 cache cleanup 2023-03-15 17:21:18 -04:00
realbigsean
cf4285e1d4 compile tests 2023-03-15 16:34:00 -04:00
realbigsean
fb7d729d92 migrate types to API crate 2023-03-15 16:03:36 -04:00
Pawan Dhananjay
49862c7e48 Add gossip verification conditions 2023-03-16 01:11:16 +05:30
realbigsean
b303d2fb7e lints 2023-03-15 15:32:22 -04:00
Pawan Dhananjay
761df83597 Initial commit 2023-03-16 00:56:18 +05:30
realbigsean
13b54f7879 shard memory blob cache 2023-03-16 00:56:16 +05:30
realbigsean
736a24e35a add 'gossip blob cache' and start to clean up processing and transition types 2023-03-16 00:53:15 +05:30
realbigsean
956ac7cbe9 small fixes 2023-03-16 00:46:33 +05:30
realbigsean
c332bc272c add intoavailableblock trait 2023-03-16 00:46:31 +05:30
realbigsean
110eaf92c4 introduce availability pending block 2023-03-16 00:45:12 +05:30
Diva M
34cea6d1c3 fmt 2023-03-15 12:37:53 -05:00
realbigsean
91a06ba484 Merge pull request #4083 from jimmygchen/post-block-and-blobs
Implement POST beacon block for EIP-4844
2023-03-15 13:35:37 -04:00
Diva M
4a39e43f96 Merge branch 'eip4844' into deneb-free-blobs 2023-03-15 12:26:30 -05:00
realbigsean
2e075c0a80 Merge pull request #4091 from realbigsean/get-validator-block-and-blobs
Get validator block and blobs
2023-03-15 12:22:03 -04:00
realbigsean
3d99e1f14d move block contents to api crate, rename blob sidecars list 2023-03-15 12:15:08 -04:00
Divma
2c9477de43 Fix block and blob coupling in the network context (#4086)
* update docs

* introduce a temp enum to model an adjusted `BlockWrapper` and fix blob coupling

* fix compilation issue

* fix blob coupling in the network context

* review comments
2023-03-15 11:04:45 -05:00
Jimmy Chen
2ef3ebbef3 Update SignedBlobSidecar container (#4078) 2023-03-15 11:03:56 -05:00
Jimmy Chen
775ca89801 Add blobs publishing 2023-03-15 15:57:30 +11:00
Jimmy Chen
5887c8fe92 Update commented code to use todo! 2023-03-15 15:29:16 +11:00
Jimmy Chen
02a88f0704 Add KZG proof and blob validation 2023-03-15 15:15:46 +11:00
Jimmy Chen
62627d984c Comment out code that fails to compile 2023-03-15 12:30:59 +11:00
Daniel Ramirez Chiquillo
1ec3041673 Remove Router/Processor Code (#4002)
## Issue Addressed

#3938 

## Proposed Changes

- `network::Processor` is deleted and all it's logic is moved to `network::Router`.
- The `network::Router` module is moved to a single file.
- The following functions are deleted: `on_disconnect` `send_status` `on_status_response` `on_blocks_by_root_request` `on_lightclient_bootstrap` `on_blocks_by_range_request` `on_block_gossip` `on_unaggregated_attestation_gossip` `on_aggregated_attestation_gossip` `on_voluntary_exit_gossip` `on_proposer_slashing_gossip` `on_attester_slashing_gossip` `on_sync_committee_signature_gossip` `on_sync_committee_contribution_gossip` `on_light_client_finality_update_gossip` `on_light_client_optimistic_update_gossip`. This deletions are possible because the updated `Router` allows the underlying methods to be called directly.
2023-03-15 01:27:47 +00:00
realbigsean
ac0eb39ced Complete match for has_context_bytes (#3972)
## Issue Addressed

- Add a complete match for `Protocol` here. 
- The incomplete match was causing us not to append context bytes to the light client protocols
- This is the relevant part of the spec and it looks like context bytes are defined https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/p2p-interface.md#getlightclientbootstrap

Disclaimer: I have no idea if people are using it but it shouldn't have been working so not sure why it wasn't caught

Co-authored-by: realbigsean <seananderson33@gmail.com>
2023-03-15 01:27:46 +00:00
Jimmy Chen
e4608d44ea Merge branch 'deneb-free-blobs' into get-validator-block-and-blobs 2023-03-15 10:55:00 +11:00
Diva M
9974dfe87b fix merge mistake 2023-03-14 14:45:17 -05:00
Diva M
7f2e9b80bb Merge branch 'unstable' into eip4844 2023-03-14 12:00:32 -05:00