lighthouse

gnosis/lighthouse

Fork 0

mirror of https://github.com/sigp/lighthouse.git synced 2026-03-17 03:42:46 +00:00

Commit Graph

Author	SHA1	Message	Date
realbigsean	7a71977987	Clippy 1.49.0 updates and dht persistence test fix (#2156 ) ## Issue Addressed `test_dht_persistence` failing ## Proposed Changes Bind `NetworkService::start` to an underscore prefixed variable rather than `_`. `_` was causing it to be dropped immediately This was failing 5/100 times before this update, but I haven't been able to get it to fail after updating it Co-authored-by: realbigsean <seananderson33@gmail.com>	2021-01-19 00:34:28 +00:00
Arthur Woimbée	851a4dca3c	replace tempdir by tempfile (#2143 ) ## Issue Addressed Fixes #2141 Remove [tempdir](https://docs.rs/tempdir/0.3.7/tempdir/) in favor of [tempfile](https://docs.rs/tempfile/3.1.0/tempfile/). ## Proposed Changes `tempfile` has a slightly different api that makes creating temp folders with a name prefix a chore (`tempdir::TempDir::new("toto")` => `tempfile::Builder::new().prefix("toto").tempdir()`). So I removed temp folder name prefix where I deemed it not useful. Otherwise, the functionality is the same.	2021-01-06 06:36:11 +00:00
Herman Junge	1a530e5a93	[Remote signer] Add signer consumer lib (#1763 ) Adds a library `common/remote_signer_consumer`	2020-11-19 04:04:52 +00:00

Author

SHA1

Message

Date

realbigsean

7a71977987

Clippy 1.49.0 updates and dht persistence test fix (#2156 )

## Issue Addressed

`test_dht_persistence` failing

## Proposed Changes

Bind `NetworkService::start` to an underscore prefixed variable rather than `_`.  `_` was causing it to be dropped immediately

This was failing 5/100 times before this update, but I haven't been able to get it to fail after updating it

Co-authored-by: realbigsean <seananderson33@gmail.com>

2021-01-19 00:34:28 +00:00

Arthur Woimbée

851a4dca3c

replace tempdir by tempfile (#2143 )

## Issue Addressed

Fixes #2141 
Remove [tempdir](https://docs.rs/tempdir/0.3.7/tempdir/) in favor of [tempfile](https://docs.rs/tempfile/3.1.0/tempfile/).

## Proposed Changes

`tempfile` has a slightly different api that makes creating temp folders with a name prefix a chore (`tempdir::TempDir::new("toto")` => `tempfile::Builder::new().prefix("toto").tempdir()`).

So I removed temp folder name prefix where I deemed it not useful.

Otherwise, the functionality is the same.

2021-01-06 06:36:11 +00:00

Herman Junge

1a530e5a93

[Remote signer] Add signer consumer lib (#1763 )

Adds a library `common/remote_signer_consumer`

2020-11-19 04:04:52 +00:00

3 Commits