mirror of https://github.com/sigp/lighthouse.git synced 2026-03-06 10:11:44 +00:00

Files

Michael Sproul ff739d56be Fix light client merkle proofs (#7007 )

Fix a regression introduced in this PR:

- https://github.com/sigp/lighthouse/pull/6361

We were indexing into the `MerkleTree` with raw generalized indices, which was incorrect and triggering `debug_assert` failures, as described here:

- https://github.com/sigp/lighthouse/issues/7005


  - Convert `generalized_index` to the correct leaf index prior to proof generation.
- Add sanity checks on indices used in `BeaconState::generate_proof`.
- Remove debug asserts from `MerkleTree::generate_proof` in favour of actual errors. This would have caught the bug earlier.
- Refactor the EF tests so that the merkle validity tests are actually run. They were misconfigured in a way that resulted in them running silently with 0 test cases, and the `check_all_files_accessed.py` script still had an ignore that covered the test files, so this omission wasn't detected.

2025-02-18 00:39:49 +00:00

src

Fix light client merkle proofs (#7007 )

2025-02-18 00:39:49 +00:00

tests

Fix light client merkle proofs (#7007 )

2025-02-18 00:39:49 +00:00

.gitignore

Add a new bls test (#3235 )

2022-10-12 23:40:42 +00:00

Cargo.toml

Enforce alphabetically ordered cargo deps (#6678 )

2024-12-19 05:46:03 +00:00

check_all_files_accessed.py

Fix light client merkle proofs (#7007 )

2025-02-18 00:39:49 +00:00

Makefile

Update EF tests to spec v1.5.0-beta.2 (#6958 )

2025-02-10 01:58:08 +00:00

README.md

Update spec tests to v1.1.0-beta.4 (#2548 )

2021-09-25 05:58:35 +00:00

README.md

Consensus Specification Tests

This crate parses and executes the test vectors at ethereum/consensus-spec-tests.

Functionality is achieved only via the $ cargo test --features ef_tests command.

Running the Tests

Because the test vectors are very large, we do not download or run them by default. To download them, run (in this directory):

$ make

Note: this may download hundreds of MB of compressed archives from the ethereum/consensus-spec-tests, which may expand into several GB of files.

If successful, you should now have the extracted tests in ./consensus-spec-tests.

Run them with:

$ cargo test --features ef_tests

The tests won't run without the ef_tests feature enabled (this is to ensure that a top-level cargo test --all won't fail on missing files).

Saving Space

When you download the tests, the downloaded archives will be kept in addition to the extracted files. You have several options for saving space:

Delete the archives (make clean-archives), and keep the extracted files. Suitable for everyday use, just don't re-run make or it will redownload the archives.
Delete the extracted files (make clean-test-files), and keep the archives. Suitable for CI, or temporarily saving space. If you re-run make it will extract the archives rather than redownloading them.
Delete everything (make clean). Good for updating to a new version, or if you no longer wish to run the EF tests.