Akihito Nakano a6d2ed6119 Fix: PeerManager doesn't remove "outbound only" peers which should be pruned (#3236) ...

## Issue Addressed

This is one step to address https://github.com/sigp/lighthouse/issues/3092 before introducing `quickcheck`.

I noticed an issue while I was reading the pruning implementation `PeerManager::prune_excess_peers()`. If a peer with the following condition, **`outbound_peers_pruned` counter increases but the peer is not pushed to `peers_to_prune`**.

- [outbound only](1e4ac8a4b9/beacon_node/lighthouse_network/src/peer_manager/mod.rs (L1018))
- [min_subnet_count <= MIN_SYNC_COMMITTEE_PEERS](1e4ac8a4b9/beacon_node/lighthouse_network/src/peer_manager/mod.rs (L1047))

As a result, PeerManager doesn't remove "outbound" peers which should be pruned.

Note: [`subnet_to_peer`](e0d673ea86/beacon_node/lighthouse_network/src/peer_manager/mod.rs (L999)) (HashMap) doesn't guarantee a particular order of iteration. So whether the test fails depend on the order of iteration.

2022-06-06 05:51:10 +00:00

..

src

Fix: PeerManager doesn't remove "outbound only" peers which should be pruned (#3236)

2022-06-06 05:51:10 +00:00

tests

Fix merge rpc length limits (#3133)

2022-04-04 00:26:15 +00:00

Cargo.toml

Separate execution payloads in the DB (#3157)

2022-05-12 00:42:17 +00:00