mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-11 18:04:18 +00:00
6c375205fb
## Issue Addressed
Fix an issue observed by `@zlan` on Discord where Lighthouse would sometimes return this error when looking up states via the API:
> {"code":500,"message":"UNHANDLED_ERROR: ForkChoiceError(MissingProtoArrayBlock(0xc9cf1495421b6ef3215d82253b388d77321176a1dcef0db0e71a0cd0ffc8cdb7))","stacktraces":[]}
## Proposed Changes
The error stems from a faulty assumption in the HTTP API logic: that any state in the hot database must have its block in fork choice. This isn't true because the state's hot database may update much less frequently than the fork choice store, e.g. if reconstructing states (where freezer migration pauses), or if the freezer migration runs slowly. There could also be a race between loading the hot state and checking fork choice, e.g. even if the finalization migration of DB+fork choice were atomic, the update could happen between the 1st and 2nd calls.
To address this I've changed the HTTP API logic to use the finalized block's execution status as a fallback where it is safe to do so. In the case where a block is non-canonical and prior to finalization (permanently orphaned) we default `execution_optimistic` to `true`.
## Additional Info
I've also added a new CLI flag to reduce the frequency of the finalization migration as this is useful for several purposes:
- Spacing out database writes (less frequent, larger batches)
- Keeping a limited chain history with high availability, e.g. the last month in the hot database.
This new flag made it _substantially_ easier to test this change. It was extracted from `tree-states` (where it's called `--db-migration-period`), which is why this PR also carries the `tree-states` label.
86 lines
2.9 KiB
Rust
86 lines
2.9 KiB
Rust
pub mod attestation_rewards;
|
|
pub mod attestation_verification;
|
|
mod attester_cache;
|
|
pub mod beacon_block_reward;
|
|
mod beacon_block_streamer;
|
|
mod beacon_chain;
|
|
mod beacon_fork_choice_store;
|
|
pub mod beacon_proposer_cache;
|
|
mod beacon_snapshot;
|
|
pub mod block_reward;
|
|
mod block_times_cache;
|
|
mod block_verification;
|
|
pub mod builder;
|
|
pub mod canonical_head;
|
|
pub mod capella_readiness;
|
|
pub mod chain_config;
|
|
mod early_attester_cache;
|
|
mod errors;
|
|
pub mod eth1_chain;
|
|
mod eth1_finalization_cache;
|
|
pub mod events;
|
|
pub mod execution_payload;
|
|
pub mod fork_choice_signal;
|
|
pub mod fork_revert;
|
|
mod head_tracker;
|
|
pub mod historical_blocks;
|
|
pub mod light_client_finality_update_verification;
|
|
pub mod light_client_optimistic_update_verification;
|
|
pub mod merge_readiness;
|
|
pub mod metrics;
|
|
pub mod migrate;
|
|
mod naive_aggregation_pool;
|
|
mod observed_aggregates;
|
|
mod observed_attesters;
|
|
pub mod observed_block_producers;
|
|
pub mod observed_operations;
|
|
pub mod otb_verification_service;
|
|
mod persisted_beacon_chain;
|
|
mod persisted_fork_choice;
|
|
mod pre_finalization_cache;
|
|
pub mod proposer_prep_service;
|
|
pub mod schema_change;
|
|
pub mod shuffling_cache;
|
|
mod snapshot_cache;
|
|
pub mod state_advance_timer;
|
|
pub mod sync_committee_rewards;
|
|
pub mod sync_committee_verification;
|
|
pub mod test_utils;
|
|
mod timeout_rw_lock;
|
|
pub mod validator_monitor;
|
|
pub mod validator_pubkey_cache;
|
|
|
|
pub use self::beacon_chain::{
|
|
AttestationProcessingOutcome, BeaconChain, BeaconChainTypes, BeaconStore, ChainSegmentResult,
|
|
ForkChoiceError, OverrideForkchoiceUpdate, ProduceBlockVerification, StateSkipConfig,
|
|
WhenSlotSkipped, INVALID_FINALIZED_MERGE_TRANSITION_BLOCK_SHUTDOWN_REASON,
|
|
INVALID_JUSTIFIED_PAYLOAD_SHUTDOWN_REASON, MAXIMUM_GOSSIP_CLOCK_DISPARITY,
|
|
};
|
|
pub use self::beacon_snapshot::BeaconSnapshot;
|
|
pub use self::chain_config::ChainConfig;
|
|
pub use self::errors::{BeaconChainError, BlockProductionError};
|
|
pub use self::historical_blocks::HistoricalBlockError;
|
|
pub use attestation_verification::Error as AttestationError;
|
|
pub use beacon_fork_choice_store::{BeaconForkChoiceStore, Error as ForkChoiceStoreError};
|
|
pub use block_verification::{
|
|
get_block_root, BlockError, ExecutionPayloadError, GossipVerifiedBlock,
|
|
IntoExecutionPendingBlock, IntoGossipVerifiedBlock,
|
|
};
|
|
pub use canonical_head::{CachedHead, CanonicalHead, CanonicalHeadRwLock};
|
|
pub use eth1_chain::{Eth1Chain, Eth1ChainBackend};
|
|
pub use events::ServerSentEventHandler;
|
|
pub use execution_layer::EngineState;
|
|
pub use execution_payload::NotifyExecutionLayer;
|
|
pub use fork_choice::{ExecutionStatus, ForkchoiceUpdateParameters};
|
|
pub use metrics::scrape_for_metrics;
|
|
pub use migrate::MigratorConfig;
|
|
pub use parking_lot;
|
|
pub use slot_clock;
|
|
pub use state_processing::per_block_processing::errors::{
|
|
AttestationValidationError, AttesterSlashingValidationError, DepositValidationError,
|
|
ExitValidationError, ProposerSlashingValidationError,
|
|
};
|
|
pub use store;
|
|
pub use timeout_rw_lock::TimeoutRwLock;
|
|
pub use types;
|