Jimmy Chen 76a37a0aef Revert incorrect fix made in #8179 (#8215) ...

This PR reverts #8179.

It turns out that the fix was invalid because an unknown root is always not a finalized descendant:

522bd9e9c6/consensus/proto_array/src/proto_array.rs (L976-L979)

so for any data columns with unknown parents, it will always penalise the gossip peer and disconnect it pretty quickly. On a small network, the node may lose all of its peers.

The impact is pretty obvious when the peer count is small and sync speed is slow, and is therefore easily reproducible by running a fresh supernode on devnet-3.

This isn't as obvious on a live testnet like holesky / sepolia, we haven't noticed this, probably due to its high peer count and sync speed - the nodes might be able to reach head quickly before losing too many peers.


  The previous behaviour isn't ideal but safe:  triggering unknown parent lookup and penalise the bad peer if it happens to be malicious or faulty. So for now it's safer to revert the change and plan for a proper fix after the v8 release.


Co-Authored-By: Jimmy Chen <jchen.tc@gmail.com>

2025-10-16 23:25:30 +00:00

..

benches

Fix data column reconstruction error (#7998)

2025-09-04 20:17:52 +00:00

src

Revert incorrect fix made in #8179 (#8215)

2025-10-16 23:25:30 +00:00

tests

#6853 Adding store tests for data column pruning (#7228)

2025-10-16 15:20:26 +00:00

Cargo.toml

Implement tracing spans for data columm RPC requests and responses (#7831)

2025-08-20 23:35:51 +00:00