mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-10 12:11:59 +00:00
## Issue Addressed #3031 ## Proposed Changes Updates the following API endpoints to conform with https://github.com/ethereum/beacon-APIs/pull/190 and https://github.com/ethereum/beacon-APIs/pull/196 - [x] `beacon/states/{state_id}/root` - [x] `beacon/states/{state_id}/fork` - [x] `beacon/states/{state_id}/finality_checkpoints` - [x] `beacon/states/{state_id}/validators` - [x] `beacon/states/{state_id}/validators/{validator_id}` - [x] `beacon/states/{state_id}/validator_balances` - [x] `beacon/states/{state_id}/committees` - [x] `beacon/states/{state_id}/sync_committees` - [x] `beacon/headers` - [x] `beacon/headers/{block_id}` - [x] `beacon/blocks/{block_id}` - [x] `beacon/blocks/{block_id}/root` - [x] `beacon/blocks/{block_id}/attestations` - [x] `debug/beacon/states/{state_id}` - [x] `debug/beacon/heads` - [x] `validator/duties/attester/{epoch}` - [x] `validator/duties/proposer/{epoch}` - [x] `validator/duties/sync/{epoch}` Updates the following Server-Sent Events: - [x] `events?topics=head` - [x] `events?topics=block` - [x] `events?topics=finalized_checkpoint` - [x] `events?topics=chain_reorg` ## Backwards Incompatible There is a very minor breaking change with the way the API now handles requests to `beacon/blocks/{block_id}/root` and `beacon/states/{state_id}/root` when `block_id` or `state_id` is the `Root` variant of `BlockId` and `StateId` respectively. Previously a request to a non-existent root would simply echo the root back to the requester: ``` curl "http://localhost:5052/eth/v1/beacon/states/0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/root" {"data":{"root":"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"}} ``` Now it will return a `404`: ``` curl "http://localhost:5052/eth/v1/beacon/blocks/0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/root" {"code":404,"message":"NOT_FOUND: beacon block with root 0xaaaa…aaaa","stacktraces":[]} ``` In addition to this is the block root `0x0000000000000000000000000000000000000000000000000000000000000000` previously would return the genesis block. It will now return a `404`: ``` curl "http://localhost:5052/eth/v1/beacon/blocks/0x0000000000000000000000000000000000000000000000000000000000000000" {"code":404,"message":"NOT_FOUND: beacon block with root 0x0000…0000","stacktraces":[]} ``` ## Additional Info - `execution_optimistic` is always set, and will return `false` pre-Bellatrix. I am also open to the idea of doing something like `#[serde(skip_serializing_if = "Option::is_none")]`. - The value of `execution_optimistic` is set to `false` where possible. Any computation that is reliant on the `head` will simply use the `ExecutionStatus` of the head (unless the head block is pre-Bellatrix). Co-authored-by: Paul Hauner <paul@paulhauner.com>
285 lines
10 KiB
Rust
285 lines
10 KiB
Rust
//! Contains the handler for the `GET validator/duties/proposer/{epoch}` endpoint.
|
|
|
|
use crate::state_id::StateId;
|
|
use beacon_chain::{
|
|
beacon_proposer_cache::{compute_proposer_duties_from_head, ensure_state_is_in_epoch},
|
|
BeaconChain, BeaconChainError, BeaconChainTypes, MAXIMUM_GOSSIP_CLOCK_DISPARITY,
|
|
};
|
|
use eth2::types::{self as api_types};
|
|
use safe_arith::SafeArith;
|
|
use slog::{debug, Logger};
|
|
use slot_clock::SlotClock;
|
|
use std::cmp::Ordering;
|
|
use types::{CloneConfig, Epoch, EthSpec, Hash256, Slot};
|
|
|
|
/// The struct that is returned to the requesting HTTP client.
|
|
type ApiDuties = api_types::DutiesResponse<Vec<api_types::ProposerData>>;
|
|
|
|
/// Handles a request from the HTTP API for proposer duties.
|
|
pub fn proposer_duties<T: BeaconChainTypes>(
|
|
request_epoch: Epoch,
|
|
chain: &BeaconChain<T>,
|
|
log: &Logger,
|
|
) -> Result<ApiDuties, warp::reject::Rejection> {
|
|
let current_epoch = chain
|
|
.epoch()
|
|
.map_err(warp_utils::reject::beacon_chain_error)?;
|
|
|
|
// Determine what the current epoch would be if we fast-forward our system clock by
|
|
// `MAXIMUM_GOSSIP_CLOCK_DISPARITY`.
|
|
//
|
|
// Most of the time, `tolerant_current_epoch` will be equal to `current_epoch`. However, during
|
|
// the first `MAXIMUM_GOSSIP_CLOCK_DISPARITY` duration of the epoch `tolerant_current_epoch`
|
|
// will equal `current_epoch + 1`
|
|
let tolerant_current_epoch = chain
|
|
.slot_clock
|
|
.now_with_future_tolerance(MAXIMUM_GOSSIP_CLOCK_DISPARITY)
|
|
.ok_or_else(|| warp_utils::reject::custom_server_error("unable to read slot clock".into()))?
|
|
.epoch(T::EthSpec::slots_per_epoch());
|
|
|
|
if request_epoch == current_epoch || request_epoch == tolerant_current_epoch {
|
|
// If we could consider ourselves in the `request_epoch` when allowing for clock disparity
|
|
// tolerance then serve this request from the cache.
|
|
if let Some(duties) = try_proposer_duties_from_cache(request_epoch, chain)? {
|
|
Ok(duties)
|
|
} else {
|
|
debug!(
|
|
log,
|
|
"Proposer cache miss";
|
|
"request_epoch" => request_epoch,
|
|
);
|
|
compute_and_cache_proposer_duties(request_epoch, chain)
|
|
}
|
|
} else if request_epoch
|
|
== current_epoch
|
|
.safe_add(1)
|
|
.map_err(warp_utils::reject::arith_error)?
|
|
{
|
|
let (proposers, dependent_root, execution_status, _fork) =
|
|
compute_proposer_duties_from_head(request_epoch, chain)
|
|
.map_err(warp_utils::reject::beacon_chain_error)?;
|
|
convert_to_api_response(
|
|
chain,
|
|
request_epoch,
|
|
dependent_root,
|
|
execution_status.is_optimistic(),
|
|
proposers,
|
|
)
|
|
} else if request_epoch
|
|
> current_epoch
|
|
.safe_add(1)
|
|
.map_err(warp_utils::reject::arith_error)?
|
|
{
|
|
// Reject queries about the future epochs for which lookahead is not possible
|
|
Err(warp_utils::reject::custom_bad_request(format!(
|
|
"request epoch {} is ahead of the next epoch {}",
|
|
request_epoch, current_epoch
|
|
)))
|
|
} else {
|
|
// request_epoch < current_epoch
|
|
//
|
|
// Queries about the past are handled with a slow path.
|
|
compute_historic_proposer_duties(request_epoch, chain)
|
|
}
|
|
}
|
|
|
|
/// Attempt to load the proposer duties from the `chain.beacon_proposer_cache`, returning `Ok(None)`
|
|
/// if there is a cache miss.
|
|
///
|
|
/// ## Notes
|
|
///
|
|
/// The `current_epoch` value should equal the current epoch on the slot clock (with some
|
|
/// tolerance), otherwise we risk washing out the proposer cache at the expense of block processing.
|
|
fn try_proposer_duties_from_cache<T: BeaconChainTypes>(
|
|
request_epoch: Epoch,
|
|
chain: &BeaconChain<T>,
|
|
) -> Result<Option<ApiDuties>, warp::reject::Rejection> {
|
|
let head = chain.canonical_head.cached_head();
|
|
let head_block = &head.snapshot.beacon_block;
|
|
let head_block_root = head.head_block_root();
|
|
let head_decision_root = head
|
|
.snapshot
|
|
.beacon_state
|
|
.proposer_shuffling_decision_root(head_block_root)
|
|
.map_err(warp_utils::reject::beacon_state_error)?;
|
|
let head_epoch = head_block.slot().epoch(T::EthSpec::slots_per_epoch());
|
|
let execution_optimistic = chain
|
|
.is_optimistic_head_block(head_block)
|
|
.map_err(warp_utils::reject::beacon_chain_error)?;
|
|
|
|
let dependent_root = match head_epoch.cmp(&request_epoch) {
|
|
// head_epoch == request_epoch
|
|
Ordering::Equal => head_decision_root,
|
|
// head_epoch < request_epoch
|
|
Ordering::Less => head_block_root,
|
|
// head_epoch > request_epoch
|
|
Ordering::Greater => {
|
|
return Err(warp_utils::reject::custom_server_error(format!(
|
|
"head epoch {} is later than request epoch {}",
|
|
head_epoch, request_epoch
|
|
)))
|
|
}
|
|
};
|
|
|
|
chain
|
|
.beacon_proposer_cache
|
|
.lock()
|
|
.get_epoch::<T::EthSpec>(dependent_root, request_epoch)
|
|
.cloned()
|
|
.map(|indices| {
|
|
convert_to_api_response(
|
|
chain,
|
|
request_epoch,
|
|
dependent_root,
|
|
execution_optimistic,
|
|
indices.to_vec(),
|
|
)
|
|
})
|
|
.transpose()
|
|
}
|
|
|
|
/// Compute the proposer duties using the head state, add the duties to the proposer cache and
|
|
/// return the proposers.
|
|
///
|
|
/// This method does *not* attempt to read the values from the cache before computing them. See
|
|
/// `try_proposer_duties_from_cache` to read values.
|
|
///
|
|
/// ## Notes
|
|
///
|
|
/// The `current_epoch` value should equal the current epoch on the slot clock, otherwise we risk
|
|
/// washing out the proposer cache at the expense of block processing.
|
|
fn compute_and_cache_proposer_duties<T: BeaconChainTypes>(
|
|
current_epoch: Epoch,
|
|
chain: &BeaconChain<T>,
|
|
) -> Result<ApiDuties, warp::reject::Rejection> {
|
|
let (indices, dependent_root, execution_status, fork) =
|
|
compute_proposer_duties_from_head(current_epoch, chain)
|
|
.map_err(warp_utils::reject::beacon_chain_error)?;
|
|
|
|
// Prime the proposer shuffling cache with the newly-learned value.
|
|
chain
|
|
.beacon_proposer_cache
|
|
.lock()
|
|
.insert(current_epoch, dependent_root, indices.clone(), fork)
|
|
.map_err(BeaconChainError::from)
|
|
.map_err(warp_utils::reject::beacon_chain_error)?;
|
|
|
|
convert_to_api_response(
|
|
chain,
|
|
current_epoch,
|
|
dependent_root,
|
|
execution_status.is_optimistic(),
|
|
indices,
|
|
)
|
|
}
|
|
|
|
/// Compute some proposer duties by reading a `BeaconState` from disk, completely ignoring the
|
|
/// `beacon_proposer_cache`.
|
|
fn compute_historic_proposer_duties<T: BeaconChainTypes>(
|
|
epoch: Epoch,
|
|
chain: &BeaconChain<T>,
|
|
) -> Result<ApiDuties, warp::reject::Rejection> {
|
|
// If the head is quite old then it might still be relevant for a historical request.
|
|
//
|
|
// Avoid holding the `cached_head` longer than necessary.
|
|
let state_opt = {
|
|
let (cached_head, execution_status) = chain
|
|
.canonical_head
|
|
.head_and_execution_status()
|
|
.map_err(warp_utils::reject::beacon_chain_error)?;
|
|
let head = &cached_head.snapshot;
|
|
|
|
if head.beacon_state.current_epoch() <= epoch {
|
|
Some((
|
|
head.beacon_state_root(),
|
|
head.beacon_state
|
|
.clone_with(CloneConfig::committee_caches_only()),
|
|
execution_status.is_optimistic(),
|
|
))
|
|
} else {
|
|
None
|
|
}
|
|
};
|
|
|
|
let (state, execution_optimistic) =
|
|
if let Some((state_root, mut state, execution_optimistic)) = state_opt {
|
|
// If we've loaded the head state it might be from a previous epoch, ensure it's in a
|
|
// suitable epoch.
|
|
ensure_state_is_in_epoch(&mut state, state_root, epoch, &chain.spec)
|
|
.map_err(warp_utils::reject::beacon_chain_error)?;
|
|
(state, execution_optimistic)
|
|
} else {
|
|
StateId::from_slot(epoch.start_slot(T::EthSpec::slots_per_epoch())).state(chain)?
|
|
};
|
|
|
|
// Ensure the state lookup was correct.
|
|
if state.current_epoch() != epoch {
|
|
return Err(warp_utils::reject::custom_server_error(format!(
|
|
"state epoch {} not equal to request epoch {}",
|
|
state.current_epoch(),
|
|
epoch
|
|
)));
|
|
}
|
|
|
|
let indices = state
|
|
.get_beacon_proposer_indices(&chain.spec)
|
|
.map_err(BeaconChainError::from)
|
|
.map_err(warp_utils::reject::beacon_chain_error)?;
|
|
|
|
// We can supply the genesis block root as the block root since we know that the only block that
|
|
// decides its own root is the genesis block.
|
|
let dependent_root = state
|
|
.proposer_shuffling_decision_root(chain.genesis_block_root)
|
|
.map_err(BeaconChainError::from)
|
|
.map_err(warp_utils::reject::beacon_chain_error)?;
|
|
|
|
convert_to_api_response(chain, epoch, dependent_root, execution_optimistic, indices)
|
|
}
|
|
|
|
/// Converts the internal representation of proposer duties into one that is compatible with the
|
|
/// standard API.
|
|
fn convert_to_api_response<T: BeaconChainTypes>(
|
|
chain: &BeaconChain<T>,
|
|
epoch: Epoch,
|
|
dependent_root: Hash256,
|
|
execution_optimistic: bool,
|
|
indices: Vec<usize>,
|
|
) -> Result<ApiDuties, warp::reject::Rejection> {
|
|
let index_to_pubkey_map = chain
|
|
.validator_pubkey_bytes_many(&indices)
|
|
.map_err(warp_utils::reject::beacon_chain_error)?;
|
|
|
|
// Map our internal data structure into the API structure.
|
|
let proposer_data = indices
|
|
.iter()
|
|
.enumerate()
|
|
.filter_map(|(i, &validator_index)| {
|
|
// Offset the index in `indices` to determine the slot for which these
|
|
// duties apply.
|
|
let slot = epoch.start_slot(T::EthSpec::slots_per_epoch()) + Slot::from(i);
|
|
|
|
Some(api_types::ProposerData {
|
|
pubkey: *index_to_pubkey_map.get(&validator_index)?,
|
|
validator_index: validator_index as u64,
|
|
slot,
|
|
})
|
|
})
|
|
.collect::<Vec<_>>();
|
|
|
|
// Consistency check.
|
|
let slots_per_epoch = T::EthSpec::slots_per_epoch() as usize;
|
|
if proposer_data.len() != slots_per_epoch {
|
|
Err(warp_utils::reject::custom_server_error(format!(
|
|
"{} proposers is not enough for {} slots",
|
|
proposer_data.len(),
|
|
slots_per_epoch,
|
|
)))
|
|
} else {
|
|
Ok(api_types::DutiesResponse {
|
|
dependent_root,
|
|
execution_optimistic: Some(execution_optimistic),
|
|
data: proposer_data,
|
|
})
|
|
}
|
|
}
|