mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-02 16:21:42 +00:00
9065e4a56e
None I noticed that `observed_column_sidecars` is missing its prune call in the finalization handler, which results in a memory leak on long-running nodes (very slow (**7MB/day**)) :13dfa9200f/beacon_node/beacon_chain/src/canonical_head.rs (L940-L959)Both caches use the same generic type `ObservedDataSidecars<T>:`22ec4b3271/beacon_node/beacon_chain/src/beacon_chain.rs (L413-L416)The type's documentation explicitly requires manual pruning: > "*The cache supports pruning based upon the finalized epoch. It does not automatically prune, you must call Self::prune manually.*"b4704eab4a/beacon_node/beacon_chain/src/observed_data_sidecars.rs (L66-L74)Currently: - `observed_blob_sidecars` => pruned - `observed_column_sidecars` => **NOT** pruned Without pruning, the underlying HashMap accumulates entries indefinitely, causing continuous memory growth until the node restarts. Co-Authored-By: Antoine James <antoine@ethereum.org>