mirror of
https://github.com/sigp/lighthouse.git
synced 2026-04-21 06:48:27 +00:00
Fix the issue with the `proposer_duties` endpoint using the wrong dependent root post-Fulu by implementing the new v2 endpoint: - https://github.com/ethereum/beacon-APIs/pull/563 We need to add this in time for Gloas, and then we can we can deprecate and remove v1. - Add a new API handler for the v2 endpoint - Add client code in the `eth2` crate - Update existing tests and add some new ones to confirm the different behaviour of v1 and v2 There's a bit of test duplication with v1, but this will be resolved once v1 and its tests are deleted. Co-Authored-By: Michael Sproul <michael@sigmaprime.io> Co-Authored-By: Michael Sproul <michaelsproul@users.noreply.github.com> Co-Authored-By: chonghe <44791194+chong-he@users.noreply.github.com>
344 lines
13 KiB
Rust
344 lines
13 KiB
Rust
//! Contains the handler for the `GET validator/duties/proposer/{epoch}` endpoint.
|
|
|
|
use crate::state_id::StateId;
|
|
use beacon_chain::{
|
|
BeaconChain, BeaconChainError, BeaconChainTypes,
|
|
beacon_proposer_cache::{
|
|
compute_proposer_duties_from_head, ensure_state_can_determine_proposers_for_epoch,
|
|
},
|
|
};
|
|
use eth2::types::{self as api_types};
|
|
use safe_arith::SafeArith;
|
|
use slot_clock::SlotClock;
|
|
use tracing::debug;
|
|
use types::{Epoch, EthSpec, Hash256, Slot};
|
|
|
|
/// Selects which dependent root to return in the API response.
|
|
///
|
|
/// - `Legacy`: the block root at the last slot of epoch N-1 (v1 behaviour, for backwards compat).
|
|
/// - `True`: the fork-aware proposer shuffling decision root (v2 behaviour). Pre-Fulu this equals
|
|
/// the legacy root; post-Fulu it uses epoch N-2.
|
|
#[derive(Clone, Copy, PartialEq, Eq)]
|
|
enum DependentRootSelection {
|
|
Legacy,
|
|
True,
|
|
}
|
|
|
|
/// The struct that is returned to the requesting HTTP client.
|
|
type ApiDuties = api_types::DutiesResponse<Vec<api_types::ProposerData>>;
|
|
|
|
/// Handles a request from the HTTP API for v1 proposer duties.
|
|
///
|
|
/// Returns the legacy dependent root (block root at end of epoch N-1) for backwards compatibility.
|
|
pub fn proposer_duties<T: BeaconChainTypes>(
|
|
request_epoch: Epoch,
|
|
chain: &BeaconChain<T>,
|
|
) -> Result<ApiDuties, warp::reject::Rejection> {
|
|
proposer_duties_internal(request_epoch, chain, DependentRootSelection::Legacy)
|
|
}
|
|
|
|
/// Handles a request from the HTTP API for v2 proposer duties.
|
|
///
|
|
/// Returns the true fork-aware dependent root. Pre-Fulu this equals the legacy root; post-Fulu it
|
|
/// uses epoch N-2 due to deterministic proposer lookahead with `min_seed_lookahead`.
|
|
pub fn proposer_duties_v2<T: BeaconChainTypes>(
|
|
request_epoch: Epoch,
|
|
chain: &BeaconChain<T>,
|
|
) -> Result<ApiDuties, warp::reject::Rejection> {
|
|
proposer_duties_internal(request_epoch, chain, DependentRootSelection::True)
|
|
}
|
|
|
|
fn proposer_duties_internal<T: BeaconChainTypes>(
|
|
request_epoch: Epoch,
|
|
chain: &BeaconChain<T>,
|
|
root_selection: DependentRootSelection,
|
|
) -> Result<ApiDuties, warp::reject::Rejection> {
|
|
let current_epoch = chain
|
|
.slot_clock
|
|
.now_or_genesis()
|
|
.map(|slot| slot.epoch(T::EthSpec::slots_per_epoch()))
|
|
.ok_or(BeaconChainError::UnableToReadSlot)
|
|
.map_err(warp_utils::reject::unhandled_error)?;
|
|
|
|
// Determine what the current epoch would be if we fast-forward our system clock by
|
|
// `MAXIMUM_GOSSIP_CLOCK_DISPARITY`.
|
|
//
|
|
// Most of the time, `tolerant_current_epoch` will be equal to `current_epoch`. However, during
|
|
// the first `MAXIMUM_GOSSIP_CLOCK_DISPARITY` duration of the epoch `tolerant_current_epoch`
|
|
// will equal `current_epoch + 1`
|
|
let tolerant_current_epoch = if chain.slot_clock.is_prior_to_genesis().unwrap_or(true) {
|
|
current_epoch
|
|
} else {
|
|
chain
|
|
.slot_clock
|
|
.now_with_future_tolerance(chain.spec.maximum_gossip_clock_disparity())
|
|
.ok_or_else(|| {
|
|
warp_utils::reject::custom_server_error("unable to read slot clock".into())
|
|
})?
|
|
.epoch(T::EthSpec::slots_per_epoch())
|
|
};
|
|
|
|
if request_epoch == current_epoch || request_epoch == tolerant_current_epoch {
|
|
// If we could consider ourselves in the `request_epoch` when allowing for clock disparity
|
|
// tolerance then serve this request from the cache.
|
|
if let Some(duties) = try_proposer_duties_from_cache(request_epoch, chain, root_selection)?
|
|
{
|
|
Ok(duties)
|
|
} else {
|
|
debug!(%request_epoch, "Proposer cache miss");
|
|
compute_and_cache_proposer_duties(request_epoch, chain, root_selection)
|
|
}
|
|
} else if request_epoch
|
|
== current_epoch
|
|
.safe_add(1)
|
|
.map_err(warp_utils::reject::arith_error)?
|
|
{
|
|
let (proposers, dependent_root, legacy_dependent_root, execution_status, _fork) =
|
|
compute_proposer_duties_from_head(request_epoch, chain)
|
|
.map_err(warp_utils::reject::unhandled_error)?;
|
|
let selected_root = match root_selection {
|
|
DependentRootSelection::Legacy => legacy_dependent_root,
|
|
DependentRootSelection::True => dependent_root,
|
|
};
|
|
convert_to_api_response(
|
|
chain,
|
|
request_epoch,
|
|
selected_root,
|
|
execution_status.is_optimistic_or_invalid(),
|
|
proposers,
|
|
)
|
|
} else if request_epoch
|
|
> current_epoch
|
|
.safe_add(1)
|
|
.map_err(warp_utils::reject::arith_error)?
|
|
{
|
|
// Reject queries about the future epochs for which lookahead is not possible
|
|
Err(warp_utils::reject::custom_bad_request(format!(
|
|
"request epoch {} is ahead of the next epoch {}",
|
|
request_epoch, current_epoch
|
|
)))
|
|
} else {
|
|
// request_epoch < current_epoch
|
|
//
|
|
// Queries about the past are handled with a slow path.
|
|
compute_historic_proposer_duties(request_epoch, chain, root_selection)
|
|
}
|
|
}
|
|
|
|
/// Attempt to load the proposer duties from the `chain.beacon_proposer_cache`, returning `Ok(None)`
|
|
/// if there is a cache miss.
|
|
///
|
|
/// ## Notes
|
|
///
|
|
/// The `current_epoch` value should equal the current epoch on the slot clock (with some
|
|
/// tolerance), otherwise we risk washing out the proposer cache at the expense of block processing.
|
|
fn try_proposer_duties_from_cache<T: BeaconChainTypes>(
|
|
request_epoch: Epoch,
|
|
chain: &BeaconChain<T>,
|
|
root_selection: DependentRootSelection,
|
|
) -> Result<Option<ApiDuties>, warp::reject::Rejection> {
|
|
let head = chain.canonical_head.cached_head();
|
|
let head_block = &head.snapshot.beacon_block;
|
|
let head_block_root = head.head_block_root();
|
|
let head_epoch = head_block.slot().epoch(T::EthSpec::slots_per_epoch());
|
|
|
|
// This code path can't handle requests for past epochs.
|
|
if head_epoch > request_epoch {
|
|
return Err(warp_utils::reject::custom_server_error(format!(
|
|
"head epoch {head_epoch} is later than request epoch {request_epoch}",
|
|
)));
|
|
}
|
|
|
|
let head_decision_root = head
|
|
.snapshot
|
|
.beacon_state
|
|
.proposer_shuffling_decision_root_at_epoch(request_epoch, head_block_root, &chain.spec)
|
|
.map_err(warp_utils::reject::beacon_state_error)?;
|
|
let selected_root = match root_selection {
|
|
DependentRootSelection::Legacy => head
|
|
.snapshot
|
|
.beacon_state
|
|
.legacy_proposer_shuffling_decision_root_at_epoch(request_epoch, head_block_root)
|
|
.map_err(warp_utils::reject::beacon_state_error)?,
|
|
DependentRootSelection::True => head_decision_root,
|
|
};
|
|
let execution_optimistic = chain
|
|
.is_optimistic_or_invalid_head_block(head_block)
|
|
.map_err(warp_utils::reject::unhandled_error)?;
|
|
|
|
chain
|
|
.beacon_proposer_cache
|
|
.lock()
|
|
.get_epoch::<T::EthSpec>(head_decision_root, request_epoch)
|
|
.cloned()
|
|
.map(|indices| {
|
|
convert_to_api_response(
|
|
chain,
|
|
request_epoch,
|
|
selected_root,
|
|
execution_optimistic,
|
|
indices.to_vec(),
|
|
)
|
|
})
|
|
.transpose()
|
|
}
|
|
|
|
/// Compute the proposer duties using the head state, add the duties to the proposer cache and
|
|
/// return the proposers.
|
|
///
|
|
/// This method does *not* attempt to read the values from the cache before computing them. See
|
|
/// `try_proposer_duties_from_cache` to read values.
|
|
///
|
|
/// ## Notes
|
|
///
|
|
/// The `current_epoch` value should equal the current epoch on the slot clock, otherwise we risk
|
|
/// washing out the proposer cache at the expense of block processing.
|
|
fn compute_and_cache_proposer_duties<T: BeaconChainTypes>(
|
|
current_epoch: Epoch,
|
|
chain: &BeaconChain<T>,
|
|
root_selection: DependentRootSelection,
|
|
) -> Result<ApiDuties, warp::reject::Rejection> {
|
|
let (indices, dependent_root, legacy_dependent_root, execution_status, fork) =
|
|
compute_proposer_duties_from_head(current_epoch, chain)
|
|
.map_err(warp_utils::reject::unhandled_error)?;
|
|
|
|
// Prime the proposer shuffling cache with the newly-learned value.
|
|
chain
|
|
.beacon_proposer_cache
|
|
.lock()
|
|
.insert(current_epoch, dependent_root, indices.clone(), fork)
|
|
.map_err(BeaconChainError::from)
|
|
.map_err(warp_utils::reject::unhandled_error)?;
|
|
|
|
let selected_root = match root_selection {
|
|
DependentRootSelection::Legacy => legacy_dependent_root,
|
|
DependentRootSelection::True => dependent_root,
|
|
};
|
|
convert_to_api_response(
|
|
chain,
|
|
current_epoch,
|
|
selected_root,
|
|
execution_status.is_optimistic_or_invalid(),
|
|
indices,
|
|
)
|
|
}
|
|
|
|
/// Compute some proposer duties by reading a `BeaconState` from disk, completely ignoring the
|
|
/// `beacon_proposer_cache`.
|
|
fn compute_historic_proposer_duties<T: BeaconChainTypes>(
|
|
epoch: Epoch,
|
|
chain: &BeaconChain<T>,
|
|
root_selection: DependentRootSelection,
|
|
) -> Result<ApiDuties, warp::reject::Rejection> {
|
|
// If the head is quite old then it might still be relevant for a historical request.
|
|
//
|
|
// Avoid holding the `cached_head` longer than necessary.
|
|
let state_opt = {
|
|
let (cached_head, execution_status) = chain
|
|
.canonical_head
|
|
.head_and_execution_status()
|
|
.map_err(warp_utils::reject::unhandled_error)?;
|
|
let head = &cached_head.snapshot;
|
|
|
|
if head.beacon_state.current_epoch() <= epoch {
|
|
Some((
|
|
head.beacon_state_root(),
|
|
head.beacon_state.clone(),
|
|
execution_status.is_optimistic_or_invalid(),
|
|
))
|
|
} else {
|
|
None
|
|
}
|
|
};
|
|
|
|
let (state, execution_optimistic) = if let Some((state_root, mut state, execution_optimistic)) =
|
|
state_opt
|
|
{
|
|
// If we've loaded the head state it might be from a previous epoch, ensure it's in a
|
|
// suitable epoch.
|
|
ensure_state_can_determine_proposers_for_epoch(&mut state, state_root, epoch, &chain.spec)
|
|
.map_err(warp_utils::reject::unhandled_error)?;
|
|
(state, execution_optimistic)
|
|
} else {
|
|
let (state, execution_optimistic, _finalized) =
|
|
StateId::from_slot(epoch.start_slot(T::EthSpec::slots_per_epoch())).state(chain)?;
|
|
(state, execution_optimistic)
|
|
};
|
|
|
|
// Ensure the state lookup was correct.
|
|
if state.current_epoch() != epoch && state.current_epoch() + 1 != epoch {
|
|
return Err(warp_utils::reject::custom_server_error(format!(
|
|
"state from epoch {} cannot serve request epoch {}",
|
|
state.current_epoch(),
|
|
epoch
|
|
)));
|
|
}
|
|
|
|
let indices = state
|
|
.get_beacon_proposer_indices(epoch, &chain.spec)
|
|
.map_err(BeaconChainError::from)
|
|
.map_err(warp_utils::reject::unhandled_error)?;
|
|
|
|
// We can supply the genesis block root as the block root since we know that the only block that
|
|
// decides its own root is the genesis block.
|
|
let selected_root = match root_selection {
|
|
DependentRootSelection::Legacy => state
|
|
.legacy_proposer_shuffling_decision_root_at_epoch(epoch, chain.genesis_block_root)
|
|
.map_err(BeaconChainError::from)
|
|
.map_err(warp_utils::reject::unhandled_error)?,
|
|
DependentRootSelection::True => state
|
|
.proposer_shuffling_decision_root_at_epoch(epoch, chain.genesis_block_root, &chain.spec)
|
|
.map_err(BeaconChainError::from)
|
|
.map_err(warp_utils::reject::unhandled_error)?,
|
|
};
|
|
|
|
convert_to_api_response(chain, epoch, selected_root, execution_optimistic, indices)
|
|
}
|
|
|
|
/// Converts the internal representation of proposer duties into one that is compatible with the
|
|
/// standard API.
|
|
fn convert_to_api_response<T: BeaconChainTypes>(
|
|
chain: &BeaconChain<T>,
|
|
epoch: Epoch,
|
|
dependent_root: Hash256,
|
|
execution_optimistic: bool,
|
|
indices: Vec<usize>,
|
|
) -> Result<ApiDuties, warp::reject::Rejection> {
|
|
let index_to_pubkey_map = chain
|
|
.validator_pubkey_bytes_many(&indices)
|
|
.map_err(warp_utils::reject::unhandled_error)?;
|
|
|
|
// Map our internal data structure into the API structure.
|
|
let proposer_data = indices
|
|
.iter()
|
|
.enumerate()
|
|
.filter_map(|(i, &validator_index)| {
|
|
// Offset the index in `indices` to determine the slot for which these
|
|
// duties apply.
|
|
let slot = epoch.start_slot(T::EthSpec::slots_per_epoch()) + Slot::from(i);
|
|
|
|
Some(api_types::ProposerData {
|
|
pubkey: *index_to_pubkey_map.get(&validator_index)?,
|
|
validator_index: validator_index as u64,
|
|
slot,
|
|
})
|
|
})
|
|
.collect::<Vec<_>>();
|
|
|
|
// Consistency check.
|
|
let slots_per_epoch = T::EthSpec::slots_per_epoch() as usize;
|
|
if proposer_data.len() != slots_per_epoch {
|
|
Err(warp_utils::reject::custom_server_error(format!(
|
|
"{} proposers is not enough for {} slots",
|
|
proposer_data.len(),
|
|
slots_per_epoch,
|
|
)))
|
|
} else {
|
|
Ok(api_types::DutiesResponse {
|
|
dependent_root,
|
|
execution_optimistic: Some(execution_optimistic),
|
|
data: proposer_data,
|
|
})
|
|
}
|
|
}
|