gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-03 00:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove column reconstruction when processing rpc requests (#8051)

Browse Source 
Co-Authored-By: Eitan Seri- Levi <eserilev@gmail.com>
This commit is contained in:
Eitan Seri-Levi
2025-09-15 22:18:25 -07:00
committed by GitHub
parent f04d5ecddd
commit 4409500f63
3 changed files with 3 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
beacon_node/network/src/network_beacon_processor/gossip_methods.rs
View File

@@ -1067,7 +1067,7 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
slot: *slot,
process_fn: Box::pin(async move {
cloned_self
.attempt_data_column_reconstruction(block_root, true)
.attempt_data_column_reconstruction(block_root)
.await;
}),
},

5
beacon_node/network/src/network_beacon_processor/mod.rs
View File

@@ -837,7 +837,6 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
async fn attempt_data_column_reconstruction(
self: &Arc<Self>,
block_root: Hash256,
publish_columns: bool,
) -> Option<AvailabilityProcessingStatus> {
// Only supernodes attempt reconstruction
if !self
@@ -852,9 +851,7 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
let result = self.chain.reconstruct_data_columns(block_root).await;
match result {
Ok(Some((availability_processing_status, data_columns_to_publish))) => {
if publish_columns {
self.publish_data_columns_gradually(data_columns_to_publish, block_root);
}
self.publish_data_columns_gradually(data_columns_to_publish, block_root);
match &availability_processing_status {
AvailabilityProcessingStatus::Imported(hash) => {
debug!(

13
beacon_node/network/src/network_beacon_processor/sync_methods.rs
View File

@@ -383,7 +383,7 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
"RPC custody data columns received"
);
let mut result = self
let result = self
.chain
.process_rpc_custody_columns(custody_columns)
.await;
@@ -404,17 +404,6 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
block_hash = %block_root,
"Missing components over rpc"
);
// Attempt reconstruction here before notifying sync, to avoid sending out more requests
// that we may no longer need.
// We don't publish columns reconstructed from rpc columns to the gossip network,
// as these are likely historic columns.
let publish_columns = false;
if let Some(availability) = self
.attempt_data_column_reconstruction(block_root, publish_columns)
.await
{
result = Ok(availability)
}
}
},
Err(BlockError::DuplicateFullyImported(_)) => {