gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-29 20:27:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(focil): simplify IL gossip slot validation to match spec

Browse Source 
Remove non-spec attestation deadline check that was incorrectly
rejecting ILs arriving in the first 1/3 of the slot. Per the heze
p2p-interface spec, ILs are valid when message.slot == current_slot
(with MAXIMUM_GOSSIP_CLOCK_DISPARITY allowance).

Also accept current_slot + 1 for clock disparity tolerance.
This commit is contained in:
Devnet Bot
2026-05-17 19:39:23 +00:00
parent 54990b9c30
commit 49c67f2632
1 changed files with 3 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
beacon_node/beacon_chain/src/inclusion_list_verification.rs
View File

@@ -57,25 +57,9 @@ impl<T: BeaconChainTypes> GossipVerifiedInclusionList<T> {
return Err(GossipInclusionListError::TooManyTransactions);
}
// TODO(focil): Spec says message.slot must equal current_slot with
// MAXIMUM_GOSSIP_CLOCK_DISPARITY allowance. We currently also accept current_slot - 1
// and add an attestation-deadline check that is not in the spec.
// See: https://github.com/ethereum/consensus-specs/blob/master/specs/heze/p2p-interface.md#inclusion_list
if message_slot != current_slot && message_slot != current_slot - 1 {
return Err(GossipInclusionListError::InvalidSlot {
message_slot,
current_slot,
});
}
let attestation_deadline = chain.spec.get_slot_duration() / 3;
let inclusion_list_delay_total =
get_slot_delay_ms(timestamp_now(), message_slot, &chain.slot_clock);
let exceeds_attestation_deadline = attestation_deadline >= inclusion_list_delay_total;
if exceeds_attestation_deadline {
// [IGNORE] The slot `message.slot` is equal to the current slot
// (with a MAXIMUM_GOSSIP_CLOCK_DISPARITY allowance)
if message_slot != current_slot && message_slot != current_slot + 1 {
return Err(GossipInclusionListError::InvalidSlot {
message_slot,
current_slot,