Apply reviewers suggestions

This commit is contained in:
Age Manning
2019-11-29 12:21:19 +11:00
parent c78fe81a89
commit 4cd6178bca
6 changed files with 7 additions and 5 deletions

View File

@@ -1,3 +1,6 @@
#![allow(clippy::type_complexity)]
#![allow(clippy::cognitive_complexity)]
use super::methods::{RPCErrorResponse, RPCResponse, RequestId};
use super::protocol::{RPCError, RPCProtocol, RPCRequest};
use super::RPCEvent;

View File

@@ -22,11 +22,8 @@ use std::time::Duration;
use tokio::io::{AsyncRead, AsyncWrite};
pub(crate) mod codec;
#[allow(clippy::type_complexity)]
#[allow(clippy::congitive_complexity)]
mod handler;
pub mod methods;
#[allow(clippy::type_complexity)]
mod protocol;
/// The return type used in the behaviour and the resultant event from the protocols handler.

View File

@@ -1,3 +1,5 @@
#![allow(clippy::type_complexity)]
use super::methods::*;
use crate::rpc::{
codec::{

View File

@@ -1,6 +1,5 @@
/// This crate provides the network server for Lighthouse.
pub mod error;
#[allow(clippy::unit_arg)]
pub mod message_handler;
pub mod service;
pub mod sync;

View File

@@ -1,3 +1,4 @@
#![allow(clippy::unit_arg)]
use crate::error;
use crate::service::NetworkMessage;
use crate::sync::MessageProcessor;

View File

@@ -965,7 +965,7 @@ impl<T: BeaconChainTypes> SyncManager<T> {
// remove any fully processed parent chains
self.parent_queue
.retain(|req| !(req.state == BlockRequestsState::ReadyToProcess));
.retain(|req| req.state != BlockRequestsState::ReadyToProcess);
re_run_poll
}
}