mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-09 19:51:47 +00:00
updates per pr review
This commit is contained in:
@@ -75,7 +75,6 @@ pub trait EthSpec: 'static + Default + Sync + Send + Clone + Debug + PartialEq +
|
||||
type EpochsPerSlashingsVector: Unsigned + Clone + Sync + Send + Debug + PartialEq;
|
||||
type HistoricalRootsLimit: Unsigned + Clone + Sync + Send + Debug + PartialEq;
|
||||
type ValidatorRegistryLimit: Unsigned + Clone + Sync + Send + Debug + PartialEq;
|
||||
type BuilderPendingWithdrawalsLimit: Unsigned + Clone + Sync + Send + Debug + PartialEq;
|
||||
/*
|
||||
* Max operations per block
|
||||
*/
|
||||
@@ -171,6 +170,7 @@ pub trait EthSpec: 'static + Default + Sync + Send + Clone + Debug + PartialEq +
|
||||
*/
|
||||
type PTCSize: Unsigned + Clone + Sync + Send + Debug + PartialEq;
|
||||
type MaxPayloadAttestations: Unsigned + Clone + Sync + Send + Debug + PartialEq;
|
||||
type BuilderPendingWithdrawalsLimit: Unsigned + Clone + Sync + Send + Debug + PartialEq;
|
||||
|
||||
fn default_spec() -> ChainSpec;
|
||||
|
||||
@@ -481,7 +481,7 @@ impl EthSpec for MainnetEthSpec {
|
||||
type MaxAttestationsElectra = U8;
|
||||
type MaxWithdrawalRequestsPerPayload = U16;
|
||||
type MaxPendingDepositsPerEpoch = U16;
|
||||
type PTCSize = U64; // todo: verify if needs to be U512 for some reason like in Mark's OG implementation
|
||||
type PTCSize = U512;
|
||||
type MaxPayloadAttestations = U2;
|
||||
|
||||
fn default_spec() -> ChainSpec {
|
||||
@@ -628,7 +628,7 @@ impl EthSpec for GnosisEthSpec {
|
||||
type CellsPerExtBlob = U128;
|
||||
type NumberOfColumns = U128;
|
||||
type ProposerLookaheadSlots = U32; // Derived from (MIN_SEED_LOOKAHEAD + 1) * SLOTS_PER_EPOCH
|
||||
type PTCSize = U64; // todo: verify if needs to be U512 for some reason like in Mark's OG implementation
|
||||
type PTCSize = U512;
|
||||
type MaxPayloadAttestations = U2;
|
||||
|
||||
fn default_spec() -> ChainSpec {
|
||||
|
||||
@@ -6,16 +6,7 @@ use test_random_derive::TestRandom;
|
||||
use tree_hash_derive::TreeHash;
|
||||
|
||||
#[derive(
|
||||
Default,
|
||||
Debug,
|
||||
Clone,
|
||||
Serialize,
|
||||
Encode,
|
||||
Decode,
|
||||
Deserialize,
|
||||
TreeHash,
|
||||
Derivative,
|
||||
TestRandom,
|
||||
Default, Debug, Clone, Serialize, Encode, Decode, Deserialize, TreeHash, Derivative, TestRandom,
|
||||
)]
|
||||
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
|
||||
#[derivative(PartialEq, Hash)]
|
||||
@@ -26,7 +17,7 @@ pub struct ExecutionBid {
|
||||
pub parent_block_root: Hash256,
|
||||
pub block_hash: ExecutionBlockHash,
|
||||
#[serde(with = "serde_utils::address_hex")]
|
||||
pub fee_recipient: Address, // todo(eip-7732): verify if this needs address_hex serialization
|
||||
pub fee_recipient: Address,
|
||||
#[serde(with = "serde_utils::quoted_u64")]
|
||||
pub gas_limit: u64,
|
||||
#[serde(with = "serde_utils::quoted_u64")]
|
||||
|
||||
@@ -15,7 +15,6 @@ pub struct PayloadAttestationData {
|
||||
pub slot: Slot,
|
||||
pub payload_present: bool,
|
||||
}
|
||||
// todo(eip-7732): Mark's implementation has PayloadStatus as an enum, but spec calls for a bool. Need to clarify this.
|
||||
|
||||
impl SignedRoot for PayloadAttestationData {}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user