gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-04-17 12:58:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

updates per pr review

Browse Source
This commit is contained in:
shane-moore
2025-07-29 20:34:03 -07:00
committed by Mark Mackey
parent 7dac892c71
commit 55951bb45f
3 changed files with 5 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
consensus/types/src/eth_spec.rs
View File

@@ -75,7 +75,6 @@ pub trait EthSpec: 'static + Default + Sync + Send + Clone + Debug + PartialEq +
type EpochsPerSlashingsVector: Unsigned + Clone + Sync + Send + Debug + PartialEq; type EpochsPerSlashingsVector: Unsigned + Clone + Sync + Send + Debug + PartialEq;
type HistoricalRootsLimit: Unsigned + Clone + Sync + Send + Debug + PartialEq; type HistoricalRootsLimit: Unsigned + Clone + Sync + Send + Debug + PartialEq;
type ValidatorRegistryLimit: Unsigned + Clone + Sync + Send + Debug + PartialEq; type ValidatorRegistryLimit: Unsigned + Clone + Sync + Send + Debug + PartialEq;
type BuilderPendingWithdrawalsLimit: Unsigned + Clone + Sync + Send + Debug + PartialEq;
/* /*
* Max operations per block * Max operations per block
*/ */
@@ -171,6 +170,7 @@ pub trait EthSpec: 'static + Default + Sync + Send + Clone + Debug + PartialEq +
*/ */
type PTCSize: Unsigned + Clone + Sync + Send + Debug + PartialEq; type PTCSize: Unsigned + Clone + Sync + Send + Debug + PartialEq;
type MaxPayloadAttestations: Unsigned + Clone + Sync + Send + Debug + PartialEq; type MaxPayloadAttestations: Unsigned + Clone + Sync + Send + Debug + PartialEq;
type BuilderPendingWithdrawalsLimit: Unsigned + Clone + Sync + Send + Debug + PartialEq;
fn default_spec() -> ChainSpec; fn default_spec() -> ChainSpec;
@@ -481,7 +481,7 @@ impl EthSpec for MainnetEthSpec {
type MaxAttestationsElectra = U8; type MaxAttestationsElectra = U8;
type MaxWithdrawalRequestsPerPayload = U16; type MaxWithdrawalRequestsPerPayload = U16;
type MaxPendingDepositsPerEpoch = U16; type MaxPendingDepositsPerEpoch = U16;
type PTCSize = U64; // todo: verify if needs to be U512 for some reason like in Mark's OG implementation type PTCSize = U512;
type MaxPayloadAttestations = U2; type MaxPayloadAttestations = U2;
fn default_spec() -> ChainSpec { fn default_spec() -> ChainSpec {
@@ -628,7 +628,7 @@ impl EthSpec for GnosisEthSpec {
type CellsPerExtBlob = U128; type CellsPerExtBlob = U128;
type NumberOfColumns = U128; type NumberOfColumns = U128;
type ProposerLookaheadSlots = U32; // Derived from (MIN_SEED_LOOKAHEAD + 1) * SLOTS_PER_EPOCH type ProposerLookaheadSlots = U32; // Derived from (MIN_SEED_LOOKAHEAD + 1) * SLOTS_PER_EPOCH
type PTCSize = U64; // todo: verify if needs to be U512 for some reason like in Mark's OG implementation type PTCSize = U512;
type MaxPayloadAttestations = U2; type MaxPayloadAttestations = U2;
fn default_spec() -> ChainSpec { fn default_spec() -> ChainSpec {

13
consensus/types/src/execution_bid.rs
View File

@@ -6,16 +6,7 @@ use test_random_derive::TestRandom;
use tree_hash_derive::TreeHash; use tree_hash_derive::TreeHash;
#[derive( #[derive(
Default, Default, Debug, Clone, Serialize, Encode, Decode, Deserialize, TreeHash, Derivative, TestRandom,
Debug,
Clone,
Serialize,
Encode,
Decode,
Deserialize,
TreeHash,
Derivative,
TestRandom,
)] )]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))] #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[derivative(PartialEq, Hash)] #[derivative(PartialEq, Hash)]
@@ -26,7 +17,7 @@ pub struct ExecutionBid {
pub parent_block_root: Hash256, pub parent_block_root: Hash256,
pub block_hash: ExecutionBlockHash, pub block_hash: ExecutionBlockHash,
#[serde(with = "serde_utils::address_hex")] #[serde(with = "serde_utils::address_hex")]
pub fee_recipient: Address, // todo(eip-7732): verify if this needs address_hex serialization pub fee_recipient: Address,
#[serde(with = "serde_utils::quoted_u64")] #[serde(with = "serde_utils::quoted_u64")]
pub gas_limit: u64, pub gas_limit: u64,
#[serde(with = "serde_utils::quoted_u64")] #[serde(with = "serde_utils::quoted_u64")]

1
consensus/types/src/payload_attestation_data.rs
View File

@@ -15,7 +15,6 @@ pub struct PayloadAttestationData {
pub slot: Slot, pub slot: Slot,
pub payload_present: bool, pub payload_present: bool,
} }
// todo(eip-7732): Mark's implementation has PayloadStatus as an enum, but spec calls for a bool. Need to clarify this.
impl SignedRoot for PayloadAttestationData {} impl SignedRoot for PayloadAttestationData {}