gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-07-01 11:54:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Some more TODOs

Browse Source
This commit is contained in:
Eitan Seri- Levi
2026-02-24 12:14:30 -08:00
parent 2093dc1f39
commit 876e6899cd
3 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
beacon_node/beacon_chain/src/payload_envelope_verification/execution_pending_envelope.rs
View File

@@ -44,6 +44,8 @@ impl<T: BeaconChainTypes> IntoExecutionPendingEnvelope<T> for GossipVerifiedEnve
let envelope = &signed_envelope.message; let envelope = &signed_envelope.message;
let payload = &envelope.payload; let payload = &envelope.payload;
// TODO(gloas)
// Verify the execution payload is valid // Verify the execution payload is valid
let payload_notifier = PayloadNotifier::new( let payload_notifier = PayloadNotifier::new(
chain.clone(), chain.clone(),

1
beacon_node/beacon_chain/src/payload_envelope_verification/payload_notifier.rs
View File

@@ -29,6 +29,7 @@ impl<T: BeaconChainTypes> PayloadNotifier<T> {
let payload_verification_status = { let payload_verification_status = {
let payload_message = &envelope.message; let payload_message = &envelope.message;
// TODO(gloas) re-asses if optimistic syncing works similarly post-gloas
match notify_execution_layer { match notify_execution_layer {
NotifyExecutionLayer::No if chain.config.optimistic_finalized_sync => { NotifyExecutionLayer::No if chain.config.optimistic_finalized_sync => {
let new_payload_request = Self::build_new_payload_request(&envelope, &block)?; let new_payload_request = Self::build_new_payload_request(&envelope, &block)?;

3
beacon_node/network/src/network_beacon_processor/gossip_methods.rs
View File

@@ -3272,7 +3272,8 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
Span::current().record("beacon_block_root", beacon_block_root.to_string()); Span::current().record("beacon_block_root", beacon_block_root.to_string());
// TODO(gloas) in process_gossip_block here we check_and_insert on the duplicate cache // TODO(gloas) in process_gossip_block here we check_and_insert on the duplicate cache
// before calling gossip_verified_block // before calling gossip_verified_block. We need this to ensure we dont try to execute the
// payload multiple times.
self.process_gossip_verified_execution_payload_envelope( self.process_gossip_verified_execution_payload_envelope(
peer_id, peer_id,