gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-06-10 01:26:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review nits: drop RpcEnvelope doc comment, rename PeerType::PayloadEnvelope, fix lookup-not-found log

Browse Source
This commit is contained in:
dapplion
2026-06-08 12:08:45 +02:00
parent f5c024e5ed
commit a29aece2cf
3 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
beacon_node/beacon_processor/src/lib.rs
View File

@@ -424,8 +424,6 @@ pub enum Work<E: EthSpec> {
process_fn: AsyncFn,
},
RpcCustodyColumn(AsyncFn),
/// An execution payload envelope fetched via RPC for a single-block lookup. Shares the
/// `rpc_blob_queue` for scheduling (similar latency/priority profile).
RpcEnvelope(AsyncFn),
ColumnReconstruction(AsyncFn),
IgnoredRpcBlock {

2
beacon_node/network/src/sync/block_lookups/mod.rs
View File

@@ -459,7 +459,7 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
let Some(lookup) = self.single_block_lookups.get_mut(&id.lookup_id) else {
debug!(
?id,
"Payload envelope returned for single block lookup not present"
"Payload envelope returned for a lookup id that doesn't exist"
);
return;
};

10
beacon_node/network/src/sync/block_lookups/single_block_lookup.rs
View File

@@ -144,14 +144,14 @@ pub enum PeerType {
/// The peer claims to have imported a FULL child of this block whose bid references
/// `ExecutionBlockHash` as its parent. Such peers can serve this block's payload envelope and
/// data columns.
GloasChild(ExecutionBlockHash),
PayloadEnvelope(ExecutionBlockHash),
}
impl PeerType {
/// `GloasChild` when the block's bid `parent_block_hash` is known (post-Gloas), else `Block`.
/// `PayloadEnvelope` when the block's bid `parent_block_hash` is known (post-Gloas), else `Block`.
pub fn new(parent_block_hash: Option<ExecutionBlockHash>) -> Self {
match parent_block_hash {
Some(execution_hash) => PeerType::GloasChild(execution_hash),
Some(execution_hash) => PeerType::PayloadEnvelope(execution_hash),
None => PeerType::Block,
}
}
@@ -211,7 +211,7 @@ impl<T: BeaconChainTypes> SingleBlockLookup<T> {
let mut gloas_child_peers = HashMap::new();
match peer_type {
PeerType::Block => {}
PeerType::GloasChild(execution_hash) => {
PeerType::PayloadEnvelope(execution_hash) => {
gloas_child_peers.insert(*execution_hash, block_peers.clone());
}
}
@@ -638,7 +638,7 @@ impl<T: BeaconChainTypes> SingleBlockLookup<T> {
pub fn add_peer(&mut self, peer_id: PeerId, peer_type: &PeerType) -> bool {
let mut added = false;
match peer_type {
PeerType::GloasChild(execution_hash) => {
PeerType::PayloadEnvelope(execution_hash) => {
// This peer claims to have imported a FULL child of this block whose bid references
// `execution_hash` as its parent. It is therefore proven to hold this block's
// payload envelope and data columns.